Chromium Code Reviews Chromium Code Reviews
Issue
938623005:
Allow multiple dart <script> tags in .sky files (Closed)
DescriptionAllow multiple dart <script> tags in .sky files
This does several things:
1. Teaches sky about asynchronous script execution. Previously once all imports
were loaded and the script text was available, we executed a script and assumed
it completed synchronously. We left the parser loop to do so, but that was fine
as the next chunk from the background thread would resume the parser. In this
change scripts now load and execute separately. The "load" step may trigger
further dart import loads which may cause the execution to happen asynchronously
which required teaching both the DartController and the HTMLScriptRunner to
take callbacks to allow HTMLDocumentParser to know to continue parsing after
the Dart script has resolved its imports and executed.
This required re-working some of how the parser executes scripts and I
re-purposed isWaitingForScripts to include "is the parser blocked" where
as before it was limited only to "does the treebuilder have a script", even
though the imports system may have had pending scripts as well.
I made HTMLScriptRunner live only as long as the script it was executing
since it only contained per-script state at this point.
2. Fixed an error reporting bug whereby we would not show errors when "init"
failed to execute, only "main". This required using the dart_mirrors_api.h
which required adding an include path to the core build. :(
3. Made it possible for a single sky file to contain multiple dart <script>
tags. Each <script> is a separate library and executes as
soon as </script> is seen. main or init is called for each. This required
mangling "urls" for these script blocks since Dart unique's libraries by urls.
Before this change it may have been possible to do <import 'foo.sky'> and then
<script>import 'foo.sky'</script> and have it work!?
R=abarth@chromium.org
BUG=
Committed: https://chromium.googlesource.com/external/mojo/+/010f28fac7de290d277995132699111184834516
Patch Set 1 #Patch Set 2 : Seems to render fine, but all tests time out #Patch Set 3 : Half the tests pass #Patch Set 4 : multiple-scripts.sky now works #Patch Set 5 : Everything passes except modules/dart-imports-loader-interaction.sky #Patch Set 6 : Run git cl format #Patch Set 7 : All works! #
Total comments: 8
Patch Set 8 : More tests #Patch Set 9 : Update test results #Messages
Total messages: 6 (1 generated)
|
