Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Unified Diff: sky/engine/core/app/AbstractModule.cpp

Issue 938623005: Allow multiple dart <script> tags in .sky files (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Update test results Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/app/AbstractModule.h ('k') | sky/engine/core/html/parser/HTMLDocumentParser.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/app/AbstractModule.cpp
diff --git a/sky/engine/core/app/AbstractModule.cpp b/sky/engine/core/app/AbstractModule.cpp
index 3cd17cf515565793e5c7b103edb8e843b2adce52..cc525fbfe0e297a296876a6ed8f4a29e474dcaca 100644
--- a/sky/engine/core/app/AbstractModule.cpp
+++ b/sky/engine/core/app/AbstractModule.cpp
@@ -22,6 +22,20 @@ AbstractModule::~AbstractModule() {
document_->setModule(nullptr);
}
+void AbstractModule::AddLibrary(RefPtr<DartValue> library,
+ TextPosition position) {
+ libraries_.append(LibraryEntry(library, position));
+}
+
+String AbstractModule::UrlForLibraryAt(TextPosition position) {
+ // TODO(eseidel): This could produce invalid urls?
+ // TODO(abarth): Mangle these library names to they're not predictable.
+ // Otherwise you could 'import url.sky' in dart and it could magically work!
+ int line = position.m_line.zeroBasedInt();
+ int column = position.m_column.zeroBasedInt();
+ return url() + String::format("#l%d,c%d", line, column);
+}
+
ExecutionContext* AbstractModule::executionContext() const {
return ContextLifecycleObserver::executionContext();
}
« no previous file with comments | « sky/engine/core/app/AbstractModule.h ('k') | sky/engine/core/html/parser/HTMLDocumentParser.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698