sky/engine/core/script/dart_loader.cc - Issue 938623005: Allow multiple dart <script> tags in .sky files

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/script/dart_loader.cc

Issue 938623005: Allow multiple dart <script> tags in .sky files (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Update test results Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/core/script/dart_loader.cc

diff --git a/sky/engine/core/script/dart_loader.cc b/sky/engine/core/script/dart_loader.cc

index cc5fc195d48a40290ecc1ba5770012e61cc16745..d3d0bd44a9e5275ca15906914b9f04e5d5c408db 100644

--- a/sky/engine/core/script/dart_loader.cc

+++ b/sky/engine/core/script/dart_loader.cc

@@ -207,6 +207,8 @@ Dart_Handle DartLoader::HandleLibraryTag(Dart_LibraryTag tag,

void DartLoader::WaitForDependencies(

const HashSet<DartDependency*>& dependencies,

const base::Closure& callback) {

+ if (dependencies.isEmpty())

+ return callback.Run();

dependency_watchers_.add(

adoptPtr(new DependencyWatcher(dependencies, callback)));

}