Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issue 938403007: Support [TypeChecking] on dependent/partial interfaces. (Closed)

Created:
5 years, 10 months ago by sof
Modified:
5 years, 10 months ago
Reviewers:
haraken, Jens Widell, bashi
CC:
blink-reviews, blink-reviews-bindings_chromium.org, vivekg_samsung, arv+blink, vivekg
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Support [TypeChecking] on dependent/partial interfaces. Have the [TypeChecking] extended attribute on a partial interface distribute down to its methods and attributes. This avoids having the interface that it extends to declare the [TypeChecking] behavior that the partial interface methods&attributes require. The attribute's value is appended to any [TypeChecking] attribute values already present on the partial interface members. R=haraken,jl@opera.com,bashi BUG=460550 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190639

Patch Set 1 #

Total comments: 2

Patch Set 2 : Improve merging of attributes #

Total comments: 2

Patch Set 3 : follow naming convention for to_list helper #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -10 lines) Patch
M Source/bindings/scripts/interface_dependency_resolver.py View 1 2 3 chunks +31 lines, -9 lines 0 comments Download
M Source/bindings/tests/idls/core/TestInterface3.idl View 1 1 chunk +2 lines, -0 lines 0 comments Download
A Source/bindings/tests/idls/core/TestPartialInterface4.idl View 1 1 chunk +10 lines, -0 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterface3.cpp View 1 6 chunks +67 lines, -1 line 0 comments Download
M Tools/Scripts/webkitpy/bindings/main.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 16 (4 generated)
sof
Please take a look. Seems like a useful little extension, needed for https://codereview.chromium.org/925953003/. afaict, this ...
5 years, 10 months ago (2015-02-21 17:45:39 UTC) #2
sof
If the case for this extension isn't sufficiently convincing, I'm fine with that & will ...
5 years, 10 months ago (2015-02-21 21:02:35 UTC) #3
haraken
LGTM https://codereview.chromium.org/938403007/diff/1/Source/bindings/tests/idls/core/TestPartialInterface4.idl File Source/bindings/tests/idls/core/TestPartialInterface4.idl (right): https://codereview.chromium.org/938403007/diff/1/Source/bindings/tests/idls/core/TestPartialInterface4.idl#newcode6 Source/bindings/tests/idls/core/TestPartialInterface4.idl:6: TypeChecking=Interface, Just to confirm: This affects methods/attributes of ...
5 years, 10 months ago (2015-02-21 22:39:48 UTC) #4
Jens Widell
LGTM
5 years, 10 months ago (2015-02-21 22:52:15 UTC) #5
sof
https://codereview.chromium.org/938403007/diff/1/Source/bindings/tests/idls/core/TestPartialInterface4.idl File Source/bindings/tests/idls/core/TestPartialInterface4.idl (right): https://codereview.chromium.org/938403007/diff/1/Source/bindings/tests/idls/core/TestPartialInterface4.idl#newcode6 Source/bindings/tests/idls/core/TestPartialInterface4.idl:6: TypeChecking=Interface, On 2015/02/21 22:39:48, haraken wrote: > > Just ...
5 years, 10 months ago (2015-02-22 14:05:16 UTC) #7
bashi
LGTM https://codereview.chromium.org/938403007/diff/20001/Source/bindings/scripts/interface_dependency_resolver.py File Source/bindings/scripts/interface_dependency_resolver.py (right): https://codereview.chromium.org/938403007/diff/20001/Source/bindings/scripts/interface_dependency_resolver.py#newcode283 Source/bindings/scripts/interface_dependency_resolver.py:283: def toList(x): nit: toList() -> to_list()
5 years, 10 months ago (2015-02-23 01:54:11 UTC) #8
haraken
LGTM
5 years, 10 months ago (2015-02-23 03:28:16 UTC) #9
sof
https://codereview.chromium.org/938403007/diff/20001/Source/bindings/scripts/interface_dependency_resolver.py File Source/bindings/scripts/interface_dependency_resolver.py (right): https://codereview.chromium.org/938403007/diff/20001/Source/bindings/scripts/interface_dependency_resolver.py#newcode283 Source/bindings/scripts/interface_dependency_resolver.py:283: def toList(x): On 2015/02/23 01:54:11, bashi1 wrote: > nit: ...
5 years, 10 months ago (2015-02-23 06:08:55 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/938403007/40001
5 years, 10 months ago (2015-02-23 06:09:44 UTC) #13
Jens Widell
LGTM This CL affects code generation for various overloads of Window.createImageBitmap(). In that case it ...
5 years, 10 months ago (2015-02-23 07:07:52 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://src.chromium.org/viewvc/blink?view=rev&revision=190639
5 years, 10 months ago (2015-02-23 07:22:21 UTC) #15
sof
5 years, 10 months ago (2015-02-23 07:34:56 UTC) #16

Powered by Google App Engine
This is Rietveld 408576698