Source/bindings/tests/idls/core/TestPartialInterface4.idl - Issue 938403007: Support [TypeChecking] on dependent/partial interfaces.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/bindings/tests/idls/core/TestPartialInterface4.idl

Issue 938403007: Support [TypeChecking] on dependent/partial interfaces. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 [	5 [

6 RuntimeEnabled=UnsafeES3APIs,	6 TypeChecking=Interface,
	haraken 2015/02/21 22:39:48 Just to confirm: This affects methods/attributes o Just to confirm: This affects methods/attributes of TestPartialInterface4 but doesn't affect methods/attributes of TestInterfaceDocument, right? sof 2015/02/22 14:05:16 Correct. I've altered the partial interface to mak Show quoted text On 2015/02/21 22:39:48, haraken wrote: > > Just to confirm: This affects methods/attributes of TestPartialInterface4 but > doesn't affect methods/attributes of TestInterfaceDocument, right? Correct. I've altered the partial interface to make verifying that easier. Also noticed that the merging of these attributes was a bit unexpected&surprising: the interface-level extended attribute value would override and replace any local ones. To continue this "principle of least astonishment"-like effort if nothing else, I tidied that up. pta(nother)l?
7 WillBeGarbageCollected	7 ] partial interface TestInterfaceDocument {

8 ] interface WebGLSampler {	8 static void voidMethodDocument(Document document);

9 };	9 };

OLD	NEW