Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 938283004: Pepper: add PPB interfaces that are missing in histograms.xml. (Closed)

Created:
5 years, 10 months ago by bbudge
Modified:
5 years, 10 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Pepper: add PPB interfaces that are missing in histograms.xml. Modifies pepper_hash_for_uma to sort the output by hash, so it's easier to compare against the histogram.xml file when searching for missing hashes. I used the following script to get an API list from src/ppapi: grep -r "PPB_" ppapi/c | grep -o "\".*;[0-9]\.[0-9]*\"" | tr '\n' ' ' BUG= R=asvitkine@chromium.org, dmichael@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/690ee0925156eb829f87f6078f0467e5efbeed49

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -1 line) Patch
M ppapi/tools/pepper_hash_for_uma.cc View 1 2 chunks +17 lines, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 9 chunks +17 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
bbudge
+asvitkine for histograms
5 years, 10 months ago (2015-02-25 22:03:30 UTC) #2
Alexei Svitkine (slow)
lgtm % nits https://codereview.chromium.org/938283004/diff/1/ppapi/tools/pepper_hash_for_uma.cc File ppapi/tools/pepper_hash_for_uma.cc (right): https://codereview.chromium.org/938283004/diff/1/ppapi/tools/pepper_hash_for_uma.cc#newcode10 ppapi/tools/pepper_hash_for_uma.cc:10: // ppapi/proxy/interface_list.cc. Nit: Can you add ...
5 years, 10 months ago (2015-02-25 22:14:21 UTC) #3
dmichael (off chromium)
lgtm with Alexei's comments. Thanks!
5 years, 10 months ago (2015-02-25 23:13:31 UTC) #4
bbudge
https://codereview.chromium.org/938283004/diff/1/ppapi/tools/pepper_hash_for_uma.cc File ppapi/tools/pepper_hash_for_uma.cc (right): https://codereview.chromium.org/938283004/diff/1/ppapi/tools/pepper_hash_for_uma.cc#newcode10 ppapi/tools/pepper_hash_for_uma.cc:10: // ppapi/proxy/interface_list.cc. On 2015/02/25 22:14:21, Alexei Svitkine wrote: > ...
5 years, 10 months ago (2015-02-26 00:13:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/938283004/20001
5 years, 10 months ago (2015-02-26 00:16:15 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ng/builds/14825) ios_rel_device_ninja_ng on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 10 months ago (2015-02-26 00:18:35 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/938283004/20001
5 years, 10 months ago (2015-02-26 01:26:41 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ng/builds/14914) ios_rel_device_ninja_ng on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 10 months ago (2015-02-26 01:28:12 UTC) #14
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/690ee0925156eb829f87f6078f0467e5efbeed49 Cr-Commit-Position: refs/heads/master@{#318170}
5 years, 10 months ago (2015-02-26 01:34:04 UTC) #15
bbudge
5 years, 10 months ago (2015-02-26 01:34:14 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
690ee0925156eb829f87f6078f0467e5efbeed49 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698