Pepper: add PPB interfaces that are missing in histograms.xml.

ppapi/tools/pepper_hash_for_uma.cc

 // Copyright (c) 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // This is a utility executable used for generating hashes for pepper
 // interfaces for inclusion in tools/metrics/histograms/histograms.xml. Every
 // interface-version pair must have a corresponding entry in the enum there.
 //
 // The hashing logic here must match the hashing logic at
 // ppapi/proxy/interface_list.cc.

[Alexei Svitkine (slow), 2015/02/25 22:14:21]

Nit: Can you add a comment about the command-line you use to run this?

i.e.

grep -r "PPB_" ppapi/c | grep -o "\".*;[0-9]\.[0-9]*\"" | tr '\n' ' '

[bbudge, 2015/02/26 00:13:57]

Done.

 
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>
 
+#include <algorithm>
+#include <vector>
+
 #include "base/hash.h"
 #include "base/macros.h"
 
 int main(int argc, char **argv) {
   if (argc < 2) {
     fprintf(stderr, "Usage: %s <interface1> <interface2> <...>\n", argv[0]);
     fprintf(stderr, "\n");
     fprintf(stderr, "Prints hashes for interface names.\n");
     fprintf(stderr, "Example: %s \"PPB_Var;1.1\" \"PPB_FileIO;1.2\"\n",
             argv[0]);
     return 1;
   }
+  std::vector<std::pair<uint32, char*>> hashes;
   for (int i = 1; i < argc; i++) {
     uint32 data = base::Hash(argv[i], strlen(argv[i]));
 
     // Strip off the signed bit because UMA doesn't support negative values,
     // but takes a signed int as input.
     int hash = static_cast<int>(data & 0x7fffffff);
-    printf("<int value=\"%d\" label=\"%s\"/>\n", hash, argv[i]);
+    hashes.push_back(std::make_pair(hash, argv[i]));
   }
+  std::sort(hashes.begin(), hashes.end());
+  for ( auto &hash : hashes ) {

[Alexei Svitkine (slow), 2015/02/25 22:14:21]

Nit: Per chromium format:

for (const auto& hash : hashes)

[bbudge, 2015/02/26 00:13:57]

Done.

+    printf("<int value=\"%d\" label=\"%s\"/>\n", hash.first, hash.second);
+  }
+
   return 0;
 }