Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Side by Side Diff: ppapi/tools/pepper_hash_for_uma.cc

Issue 938283004: Pepper: add PPB interfaces that are missing in histograms.xml. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address review comments. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2014 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // This is a utility executable used for generating hashes for pepper 5 // This is a utility executable used for generating hashes for pepper
6 // interfaces for inclusion in tools/metrics/histograms/histograms.xml. Every 6 // interfaces for inclusion in tools/metrics/histograms/histograms.xml. Every
7 // interface-version pair must have a corresponding entry in the enum there. 7 // interface-version pair must have a corresponding entry in the enum there.
8 // 8 //
9 // The hashing logic here must match the hashing logic at 9 // The hashing logic here must match the hashing logic at
10 // ppapi/proxy/interface_list.cc. 10 // ppapi/proxy/interface_list.cc.
11 //
12 // This utility can be used to generate a sorted list of hashes for all current
13 // PPB* interfaces by running a script to generate the interface names, e.g.
14 // $ grep -r "PPB_" ppapi/c | grep -o "\".*;[0-9]*\.[0-9]*\"" | tr '\n' ' '
15 // and then invoking pepper_hash_for_uma on the list. The sorted output hashes
16 // can be compared to tools/metrics/histograms/histograms.xml to determine if
17 // any interfaces have been left out.
11 18
12 #include <stdio.h> 19 #include <stdio.h>
13 #include <stdlib.h> 20 #include <stdlib.h>
14 #include <string.h> 21 #include <string.h>
15 22
23 #include <algorithm>
24 #include <vector>
25
16 #include "base/hash.h" 26 #include "base/hash.h"
17 #include "base/macros.h" 27 #include "base/macros.h"
18 28
19 int main(int argc, char **argv) { 29 int main(int argc, char **argv) {
20 if (argc < 2) { 30 if (argc < 2) {
21 fprintf(stderr, "Usage: %s <interface1> <interface2> <...>\n", argv[0]); 31 fprintf(stderr, "Usage: %s <interface1> <interface2> <...>\n", argv[0]);
22 fprintf(stderr, "\n"); 32 fprintf(stderr, "\n");
23 fprintf(stderr, "Prints hashes for interface names.\n"); 33 fprintf(stderr, "Prints hashes for interface names.\n");
24 fprintf(stderr, "Example: %s \"PPB_Var;1.1\" \"PPB_FileIO;1.2\"\n", 34 fprintf(stderr, "Example: %s \"PPB_Var;1.1\" \"PPB_FileIO;1.2\"\n",
25 argv[0]); 35 argv[0]);
26 return 1; 36 return 1;
27 } 37 }
38 std::vector<std::pair<uint32, char*>> hashes;
28 for (int i = 1; i < argc; i++) { 39 for (int i = 1; i < argc; i++) {
29 uint32 data = base::Hash(argv[i], strlen(argv[i])); 40 uint32 data = base::Hash(argv[i], strlen(argv[i]));
30 41
31 // Strip off the signed bit because UMA doesn't support negative values, 42 // Strip off the signed bit because UMA doesn't support negative values,
32 // but takes a signed int as input. 43 // but takes a signed int as input.
33 int hash = static_cast<int>(data & 0x7fffffff); 44 int hash = static_cast<int>(data & 0x7fffffff);
34 printf("<int value=\"%d\" label=\"%s\"/>\n", hash, argv[i]); 45 hashes.push_back(std::make_pair(hash, argv[i]));
35 } 46 }
47 std::sort(hashes.begin(), hashes.end());
48 for (const auto& hash : hashes) {
49 printf("<int value=\"%d\" label=\"%s\"/>\n", hash.first, hash.second);
50 }
51
36 return 0; 52 return 0;
37 } 53 }
OLDNEW
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698