chrome/common/extensions/manifest_handlers/minimum_chrome_version_checker.cc - Issue 93793010: Update uses of UTF conversions in chrome/common to use the base:: namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/manifest_handlers/minimum_chrome_version_checker.cc

Issue 93793010: Update uses of UTF conversions in chrome/common to use the base:: namespace. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/manifest_handlers/icons_handler.cc ('k') | chrome/common/extensions/manifest_handlers/nacl_modules_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/manifest_handlers/minimum_chrome_version_checker.cc

diff --git a/chrome/common/extensions/manifest_handlers/minimum_chrome_version_checker.cc b/chrome/common/extensions/manifest_handlers/minimum_chrome_version_checker.cc

index e9d8cee3b1c1132a97c57a33b5a81db0e366527a..8f63db6fb744374c57c37b83f73d5c6827cab87f 100644

--- a/chrome/common/extensions/manifest_handlers/minimum_chrome_version_checker.cc

+++ b/chrome/common/extensions/manifest_handlers/minimum_chrome_version_checker.cc

@@ -29,13 +29,13 @@ bool MinimumChromeVersionChecker::Parse(Extension* extension,

std::string minimum_version_string;

if (!extension->manifest()->GetString(keys::kMinimumChromeVersion,

&minimum_version_string)) {

- *error = ASCIIToUTF16(errors::kInvalidMinimumChromeVersion);

+ *error = base::ASCIIToUTF16(errors::kInvalidMinimumChromeVersion);

return false;

}

base::Version minimum_version(minimum_version_string);

if (!minimum_version.IsValid()) {

- *error = ASCIIToUTF16(errors::kInvalidMinimumChromeVersion);

+ *error = base::ASCIIToUTF16(errors::kInvalidMinimumChromeVersion);

return false;

}