chrome/common/extensions/manifest_handlers/nacl_modules_handler.cc - Issue 93793010: Update uses of UTF conversions in chrome/common to use the base:: namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/manifest_handlers/nacl_modules_handler.cc

Issue 93793010: Update uses of UTF conversions in chrome/common to use the base:: namespace. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/manifest_handlers/minimum_chrome_version_checker.cc ('k') | chrome/common/extensions/manifest_handlers/settings_overrides_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/manifest_handlers/nacl_modules_handler.cc

diff --git a/chrome/common/extensions/manifest_handlers/nacl_modules_handler.cc b/chrome/common/extensions/manifest_handlers/nacl_modules_handler.cc

index 9adae299a73ab15beca4666c1769f2904bbd600d..b6968b87dd364c003cff95c4f518b031ded3540b 100644

--- a/chrome/common/extensions/manifest_handlers/nacl_modules_handler.cc

+++ b/chrome/common/extensions/manifest_handlers/nacl_modules_handler.cc

@@ -43,7 +43,7 @@ NaClModulesHandler::~NaClModulesHandler() {

bool NaClModulesHandler::Parse(Extension* extension, base::string16* error) {

const base::ListValue* list_value = NULL;

if (!extension->manifest()->GetList(keys::kNaClModules, &list_value)) {

- *error = ASCIIToUTF16(errors::kInvalidNaClModules);

+ *error = base::ASCIIToUTF16(errors::kInvalidNaClModules);

return false;

}

@@ -52,7 +52,7 @@ bool NaClModulesHandler::Parse(Extension* extension, base::string16* error) {

for (size_t i = 0; i < list_value->GetSize(); ++i) {

const base::DictionaryValue* module_value = NULL;

if (!list_value->GetDictionary(i, &module_value)) {

- *error = ASCIIToUTF16(errors::kInvalidNaClModules);

+ *error = base::ASCIIToUTF16(errors::kInvalidNaClModules);

return false;

}