chrome/common/extensions/manifest_handlers/icons_handler.cc - Issue 93793010: Update uses of UTF conversions in chrome/common to use the base:: namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/manifest_handlers/icons_handler.cc

Issue 93793010: Update uses of UTF conversions in chrome/common to use the base:: namespace. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/manifest_handlers/content_scripts_handler.cc ('k') | chrome/common/extensions/manifest_handlers/minimum_chrome_version_checker.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/manifest_handlers/icons_handler.cc

diff --git a/chrome/common/extensions/manifest_handlers/icons_handler.cc b/chrome/common/extensions/manifest_handlers/icons_handler.cc

index 779d59d9f3a592683450ee37ecf6a10d9f0c3c46..797562c6f43b64d1ef7188a76525b20ae93f5ab5 100644

--- a/chrome/common/extensions/manifest_handlers/icons_handler.cc

+++ b/chrome/common/extensions/manifest_handlers/icons_handler.cc

@@ -77,7 +77,7 @@ bool IconsHandler::Parse(Extension* extension, base::string16* error) {

scoped_ptr<IconsInfo> icons_info(new IconsInfo);

const base::DictionaryValue* icons_dict = NULL;

if (!extension->manifest()->GetDictionary(keys::kIcons, &icons_dict)) {

- *error = ASCIIToUTF16(manifest_errors::kInvalidIcons);

+ *error = base::ASCIIToUTF16(manifest_errors::kInvalidIcons);

return false;

}