Issue 937443002: Throw exception for null listener in addEventListener

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 937443002: Throw exception for null listener in addEventListener (Closed)

Created:
5 years, 10 months ago by abarth-chromium

Modified:
5 years, 10 months ago

Reviewers:
esprehn, ojan

CC:
ojan, esprehn, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+27 lines, -13 lines)			Patch
M	sky/engine/bindings/dart_event_listener.h	View	1 chunk	+1 line, -6 lines	0 comments	Download
M	sky/engine/bindings/dart_event_listener.cc	View	2 chunks	+15 lines, -0 lines	0 comments	Download
M	sky/engine/tonic/dart_exception_factory.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	sky/engine/tonic/dart_exception_factory.cc	View	2 chunks	+9 lines, -0 lines	0 comments	Download
M	sky/engine/tonic/dart_wrappable.cc	View	2 chunks	+1 line, -7 lines	0 comments	Download

Total messages: 4 (1 generated)

abarth-chromium

5 years, 10 months ago (2015-02-17 18:49:56 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
4b656b91954eed098c772b85b4b007e4f256fd34 (presubmit successful).