Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Side by Side Diff: sky/engine/tonic/dart_exception_factory.cc

Issue 937443002: Throw exception for null listener in addEventListener (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « sky/engine/tonic/dart_exception_factory.h ('k') | sky/engine/tonic/dart_wrappable.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "sky/engine/config.h" 5 #include "sky/engine/config.h"
6 #include "sky/engine/tonic/dart_exception_factory.h" 6 #include "sky/engine/tonic/dart_exception_factory.h"
7 7
8 #include "sky/engine/tonic/dart_converter.h" 8 #include "sky/engine/tonic/dart_converter.h"
9 #include "sky/engine/tonic/dart_builtin.h" 9 #include "sky/engine/tonic/dart_builtin.h"
10 #include "sky/engine/wtf/text/StringBuilder.h"
10 11
11 namespace blink { 12 namespace blink {
12 13
13 DartExceptionFactory::DartExceptionFactory(DartState* dart_state) 14 DartExceptionFactory::DartExceptionFactory(DartState* dart_state)
14 : dart_state_(dart_state) { 15 : dart_state_(dart_state) {
15 } 16 }
16 17
17 DartExceptionFactory::~DartExceptionFactory() { 18 DartExceptionFactory::~DartExceptionFactory() {
18 } 19 }
19 20
21 Dart_Handle DartExceptionFactory::CreateNullArgumentException(int index) {
22 StringBuilder message;
23 message.appendLiteral("Argument ");
24 message.appendNumber(index);
25 message.appendLiteral(" cannot be null.");
26 return CreateException("ArgumentError", message.toString());
27 }
28
20 Dart_Handle DartExceptionFactory::CreateException(const String& class_name, 29 Dart_Handle DartExceptionFactory::CreateException(const String& class_name,
21 const String& message) { 30 const String& message) {
22 if (core_library_.is_empty()) { 31 if (core_library_.is_empty()) {
23 Dart_Handle library = DartBuiltin::LookupLibrary("dart:core"); 32 Dart_Handle library = DartBuiltin::LookupLibrary("dart:core");
24 core_library_.Set(dart_state_, library); 33 core_library_.Set(dart_state_, library);
25 } 34 }
26 35
27 Dart_Handle exception_class = Dart_GetType( 36 Dart_Handle exception_class = Dart_GetType(
28 core_library_.value(), StringToDart(dart_state_, class_name), 0, 0); 37 core_library_.value(), StringToDart(dart_state_, class_name), 0, 0);
29 Dart_Handle message_handle = StringToDart(dart_state_, message); 38 Dart_Handle message_handle = StringToDart(dart_state_, message);
30 Dart_Handle empty_string = Dart_NewStringFromCString(""); 39 Dart_Handle empty_string = Dart_NewStringFromCString("");
31 return Dart_New(exception_class, empty_string, 1, &message_handle); 40 return Dart_New(exception_class, empty_string, 1, &message_handle);
32 } 41 }
33 42
34 } // namespace blink 43 } // namespace blink
OLDNEW
« no previous file with comments | « sky/engine/tonic/dart_exception_factory.h ('k') | sky/engine/tonic/dart_wrappable.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698