Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1079)

Unified Diff: sky/engine/bindings/dart_event_listener.h

Issue 937443002: Throw exception for null listener in addEventListener (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sky/engine/bindings/dart_event_listener.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/bindings/dart_event_listener.h
diff --git a/sky/engine/bindings/dart_event_listener.h b/sky/engine/bindings/dart_event_listener.h
index d8a901731b04ebdb39d2467b9c9f03809276eb26..cb293156683250ee3e31e48c5e88eca2cd931662 100644
--- a/sky/engine/bindings/dart_event_listener.h
+++ b/sky/engine/bindings/dart_event_listener.h
@@ -51,12 +51,7 @@ struct DartConverter<EventListener*> {
static PassRefPtr<EventListener> FromArgumentsWithNullCheck(
Dart_NativeArguments args,
int index,
- Dart_Handle& exception) {
- Dart_Handle handle = Dart_GetNativeArgument(args, index);
- if (Dart_IsNull(handle))
- return nullptr;
- return FromDart(handle);
- }
+ Dart_Handle& exception);
};
} // namespace blink
« no previous file with comments | « no previous file | sky/engine/bindings/dart_event_listener.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698