Source/core/html/HTMLLegendElement.h - Issue 93723003: Rename HTMLElement::form() to formOwner().

Unified Diff: Source/core/html/HTMLLegendElement.h

Issue 93723003: Rename HTMLElement::form() to formOwner(). (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/HTMLLegendElement.h

diff --git a/Source/core/html/HTMLLegendElement.h b/Source/core/html/HTMLLegendElement.h

index 4a8c2fa6caa3943aaf9d3629f1bbb42e6970de63..74290a8ea33c715dc70752d899b7c0dbc40b3f33 100644

--- a/Source/core/html/HTMLLegendElement.h

+++ b/Source/core/html/HTMLLegendElement.h

@@ -34,6 +34,8 @@ class HTMLLegendElement FINAL : public HTMLElement {

public:

static PassRefPtr<HTMLLegendElement> create(Document&);

+ HTMLFormElement* form() const;

tkent 2013/12/10 08:31:28 Why do you add it?

sof 2013/12/10 08:35:29 The legend element has its own notion of 'form',

tkent 2013/12/10 08:49:49 So, this CL is not a simple renaming. The CL desc

sof 2013/12/10 08:53:57 It introduces "form owner" where it makes sense, y

sof 2013/12/10 09:03:01 Done.

private:

explicit HTMLLegendElement(Document&);

@@ -42,7 +44,6 @@ private:

virtual void accessKeyAction(bool sendMouseEvents);

virtual void focus(bool restorePreviousSelection, FocusDirection) OVERRIDE;

- virtual HTMLFormElement* virtualForm() const OVERRIDE;

tkent 2013/12/10 08:31:28 Why do you remove it?

sof 2013/12/10 08:35:29 Now unused.

};

DEFINE_NODE_TYPE_CASTS(HTMLLegendElement, hasTagName(HTMLNames::legendTag));