Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(637)

Unified Diff: Source/core/html/HTMLFormControlElement.h

Issue 93723003: Rename HTMLElement::form() to formOwner(). (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/HTMLFormControlElement.h
diff --git a/Source/core/html/HTMLFormControlElement.h b/Source/core/html/HTMLFormControlElement.h
index 391dae36441335f283b1c1b035e5ecab34e9b370..f2699a098af85dd80054232b5d320497dfc02bf3 100644
--- a/Source/core/html/HTMLFormControlElement.h
+++ b/Source/core/html/HTMLFormControlElement.h
@@ -43,8 +43,6 @@ class HTMLFormControlElement : public LabelableElement, public FormAssociatedEle
public:
virtual ~HTMLFormControlElement();
- HTMLFormElement* form() const { return FormAssociatedElement::form(); }
tkent 2013/12/10 08:31:28 Why do you remove it?
sof 2013/12/10 08:35:29 FormAssociatedElement::form() implements it.
tkent 2013/12/10 08:49:49 form() IDL function uses HTMLElement::formOwner()
sof 2013/12/10 08:53:57 Which IDL function/attribute "form" are you referr
sof 2013/12/10 08:56:41 (Please also notice the virtualForm() overloads of
tkent 2013/12/10 08:59:01 Oops, it's not an IDL function. I meant 'form' ID
sof 2013/12/10 09:03:01 Same functionality/behavior is provided, see HTMLF
tkent 2013/12/10 09:07:50 ok, I understand. I expect only literal renaming
-
String formEnctype() const;
void setFormEnctype(const AtomicString&);
String formMethod() const;

Powered by Google App Engine
This is Rietveld 408576698