Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Side by Side Diff: Source/core/html/HTMLLegendElement.h

Issue 93723003: Rename HTMLElement::form() to formOwner(). (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Dirk Mueller (mueller@kde.org) 4 * (C) 2000 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2010 Apple Inc. All rights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2010 Apple Inc. All rights reserved.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 16 matching lines...) Expand all
27 #include "core/html/HTMLElement.h" 27 #include "core/html/HTMLElement.h"
28 28
29 namespace WebCore { 29 namespace WebCore {
30 30
31 class HTMLFormControlElement; 31 class HTMLFormControlElement;
32 32
33 class HTMLLegendElement FINAL : public HTMLElement { 33 class HTMLLegendElement FINAL : public HTMLElement {
34 public: 34 public:
35 static PassRefPtr<HTMLLegendElement> create(Document&); 35 static PassRefPtr<HTMLLegendElement> create(Document&);
36 36
37 HTMLFormElement* form() const;
tkent 2013/12/10 08:31:28 Why do you add it?
sof 2013/12/10 08:35:29 The legend element has its own notion of 'form',
tkent 2013/12/10 08:49:49 So, this CL is not a simple renaming. The CL desc
sof 2013/12/10 08:53:57 It introduces "form owner" where it makes sense, y
sof 2013/12/10 09:03:01 Done.
38
37 private: 39 private:
38 explicit HTMLLegendElement(Document&); 40 explicit HTMLLegendElement(Document&);
39 41
40 // Control in the legend's fieldset that gets focus and access key. 42 // Control in the legend's fieldset that gets focus and access key.
41 HTMLFormControlElement* associatedControl(); 43 HTMLFormControlElement* associatedControl();
42 44
43 virtual void accessKeyAction(bool sendMouseEvents); 45 virtual void accessKeyAction(bool sendMouseEvents);
44 virtual void focus(bool restorePreviousSelection, FocusDirection) OVERRIDE; 46 virtual void focus(bool restorePreviousSelection, FocusDirection) OVERRIDE;
45 virtual HTMLFormElement* virtualForm() const OVERRIDE;
tkent 2013/12/10 08:31:28 Why do you remove it?
sof 2013/12/10 08:35:29 Now unused.
46 }; 47 };
47 48
48 DEFINE_NODE_TYPE_CASTS(HTMLLegendElement, hasTagName(HTMLNames::legendTag)); 49 DEFINE_NODE_TYPE_CASTS(HTMLLegendElement, hasTagName(HTMLNames::legendTag));
49 50
50 } //namespace 51 } //namespace
51 52
52 #endif 53 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698