Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Side by Side Diff: Source/core/html/HTMLFormControlElement.h

Issue 93723003: Rename HTMLElement::form() to formOwner(). (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Dirk Mueller (mueller@kde.org) 4 * (C) 2000 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 25 matching lines...) Expand all
36 class ValidationMessage; 36 class ValidationMessage;
37 class ValidityState; 37 class ValidityState;
38 38
39 // HTMLFormControlElement is the default implementation of FormAssociatedElement , 39 // HTMLFormControlElement is the default implementation of FormAssociatedElement ,
40 // and form-associated element implementations should use HTMLFormControlElement 40 // and form-associated element implementations should use HTMLFormControlElement
41 // unless there is a special reason. 41 // unless there is a special reason.
42 class HTMLFormControlElement : public LabelableElement, public FormAssociatedEle ment { 42 class HTMLFormControlElement : public LabelableElement, public FormAssociatedEle ment {
43 public: 43 public:
44 virtual ~HTMLFormControlElement(); 44 virtual ~HTMLFormControlElement();
45 45
46 HTMLFormElement* form() const { return FormAssociatedElement::form(); }
tkent 2013/12/10 08:31:28 Why do you remove it?
sof 2013/12/10 08:35:29 FormAssociatedElement::form() implements it.
tkent 2013/12/10 08:49:49 form() IDL function uses HTMLElement::formOwner()
sof 2013/12/10 08:53:57 Which IDL function/attribute "form" are you referr
sof 2013/12/10 08:56:41 (Please also notice the virtualForm() overloads of
tkent 2013/12/10 08:59:01 Oops, it's not an IDL function. I meant 'form' ID
sof 2013/12/10 09:03:01 Same functionality/behavior is provided, see HTMLF
tkent 2013/12/10 09:07:50 ok, I understand. I expect only literal renaming
47
48 String formEnctype() const; 46 String formEnctype() const;
49 void setFormEnctype(const AtomicString&); 47 void setFormEnctype(const AtomicString&);
50 String formMethod() const; 48 String formMethod() const;
51 void setFormMethod(const AtomicString&); 49 void setFormMethod(const AtomicString&);
52 bool formNoValidate() const; 50 bool formNoValidate() const;
53 51
54 void ancestorDisabledStateWasChanged(); 52 void ancestorDisabledStateWasChanged();
55 53
56 void reset(); 54 void reset();
57 55
(...skipping 150 matching lines...) Expand 10 before | Expand all | Expand 10 after
208 206
209 inline const HTMLFormControlElement& toHTMLFormControlElement(const FormAssociat edElement& control) 207 inline const HTMLFormControlElement& toHTMLFormControlElement(const FormAssociat edElement& control)
210 { 208 {
211 ASSERT_WITH_SECURITY_IMPLICATION(control.isFormControlElement()); 209 ASSERT_WITH_SECURITY_IMPLICATION(control.isFormControlElement());
212 return static_cast<const HTMLFormControlElement&>(control); 210 return static_cast<const HTMLFormControlElement&>(control);
213 } 211 }
214 212
215 } // namespace 213 } // namespace
216 214
217 #endif 215 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698