Move IME shortcut keys from X to Aura [part 1 of 3].

Move IME shortcut keys from X to Aura [part 1 of 3].

- Add ash::ImeControlDelegate interface.
- Call a method in the interface when an IME shortcut is pressed.
- Modify ash::AcceleratorController so that it could handle pre- and post-IME shortcuts separately.

BUG=110408
TEST=ran aura_shell_unittests


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=122411

[Yusuke Sato, 2012-02-13 08:11:55]

mazda: added ui::EventType to ui::Accelerator following your suggestion. PTAL.

[mazda, 2012-02-13 08:36:06]

lgtm with a nit

http://codereview.chromium.org/9370017/diff/8001/ui/base/accelerators/acceler...
File ui/base/accelerators/accelerator.h (right):

http://codereview.chromium.org/9370017/diff/8001/ui/base/accelerators/acceler...
ui/base/accelerators/accelerator.h:85: ui::EventType type() const { return
type_; }
nit: insert an empty line

[Yusuke Sato, 2012-02-13 08:45:32]

+ben
Could you review this?

http://codereview.chromium.org/9370017/diff/8001/ui/base/accelerators/acceler...
File ui/base/accelerators/accelerator.h (right):

http://codereview.chromium.org/9370017/diff/8001/ui/base/accelerators/acceler...
ui/base/accelerators/accelerator.h:85: ui::EventType type() const { return
type_; }
On 2012/02/13 08:36:06, mazda wrote:
> nit: insert an empty line

Done.

[Ben Goodger (Google), 2012-02-14 17:49:06]

I appear to be missing the code where accelerator.type() is inspected. (I just
see you setting it in a few places).

[Yusuke Sato, 2012-02-15 01:18:23]

On 2012/02/14 17:49:06, Ben Goodger (Google) wrote:
> I appear to be missing the code where accelerator.type() is inspected. (I just
> see you setting it in a few places).

The type is checked in ui::Accelerator::operator==():
http://codereview.chromium.org/9370017/diff/10002/ui/base/accelerators/accele...

and the operator== is invoked here:

bool AcceleratorManager::Process(const Accelerator& accelerator) {
  AcceleratorMap::iterator map_iter = accelerators_.find(accelerator);

http://src.chromium.org/viewvc/chrome/trunk/src/ui/base/accelerators/accelera...

Thanks,
-Yusuke

[Yusuke Sato, 2012-02-15 01:20:00]

Sorry, I mean operator<(), not ==().

-Yusuke

On 2012/02/15 01:18:23, Yusuke Sato wrote:
> On 2012/02/14 17:49:06, Ben Goodger (Google) wrote:
> > I appear to be missing the code where accelerator.type() is inspected. (I
just
> > see you setting it in a few places).
> 
> The type is checked in ui::Accelerator::operator==():
>
http://codereview.chromium.org/9370017/diff/10002/ui/base/accelerators/accele...
> 
> and the operator== is invoked here:
> 
> bool AcceleratorManager::Process(const Accelerator& accelerator) {
>   AcceleratorMap::iterator map_iter = accelerators_.find(accelerator);
> 
>
http://src.chromium.org/viewvc/chrome/trunk/src/ui/base/accelerators/accelera...
> 
> Thanks,
> -Yusuke

[Ben Goodger (Google), 2012-02-15 22:17:22]

I saw it now in the other CL, so this is LGTM.

On Tue, Feb 14, 2012 at 5:20 PM, <yusukes@chromium.org> wrote:

> Sorry, I mean operator<(), not ==().
>
> -Yusuke
>
>
> On 2012/02/15 01:18:23, Yusuke Sato wrote:
>
>> On 2012/02/14 17:49:06, Ben Goodger (Google) wrote:
>> > I appear to be missing the code where accelerator.type() is inspected.
>> (I
>>
> just
>
>> > see you setting it in a few places).
>>
>
>  The type is checked in ui::Accelerator::operator==():
>>
>
> http://codereview.chromium.**org/9370017/diff/10002/ui/**
>
base/accelerators/accelerator.**h<http://codereview.chromium.org/9370017/diff/10002/ui/base/accelerators/accelerator.h>
>
>  and the operator== is invoked here:
>>
>
>  bool AcceleratorManager::Process(**const Accelerator& accelerator) {
>>   AcceleratorMap::iterator map_iter = accelerators_.find(**accelerator);
>>
>
>
> http://src.chromium.org/**viewvc/chrome/trunk/src/ui/**
>
base/accelerators/accelerator_**manager.cc?view=markup<http://src.chromium.org/viewvc/chrome/trunk/src/ui/base/accelerators/accelerator_manager.cc?view=markup>
>
>  Thanks,
>> -Yusuke
>>
>
>
>
>
http://codereview.chromium.**org/9370017/<http://codereview.chromium.org/9370...
>

[commit-bot: I haz the power, 2012-02-16 12:23:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yusukes@chromium.org/9370017/16001

[commit-bot: I haz the power, 2012-02-16 13:38:24]

Can't apply patch for file ash/accelerators/accelerator_controller_unittest.cc.
While running patch -p1 --forward --force;
patching file ash/accelerators/accelerator_controller_unittest.cc
Hunk #2 succeeded at 52 with fuzz 1.
Hunk #3 succeeded at 209 (offset 7 lines).
Hunk #4 succeeded at 360 (offset 7 lines).
Hunk #5 FAILED at 396.
Hunk #6 succeeded at 456 (offset 10 lines).
Hunk #7 succeeded at 501 (offset 10 lines).
Hunk #8 succeeded at 542 (offset 10 lines).
Hunk #9 succeeded at 576 (offset 10 lines).
Hunk #10 succeeded at 612 (offset 10 lines).
1 out of 10 hunks FAILED -- saving rejects to file
ash/accelerators/accelerator_controller_unittest.cc.rej

[commit-bot: I haz the power, 2012-02-16 22:59:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yusukes@chromium.org/9370017/20003

[commit-bot: I haz the power, 2012-02-17 00:30:07]

Change committed as 122411