Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3412)

Unified Diff: ash/shell.cc

Issue 9370017: Move IME shortcut keys from X to Aura [part 1 of 3]. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: re-rebase... Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/ime_control_delegate.h ('k') | ui/base/accelerators/accelerator.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/shell.cc
diff --git a/ash/shell.cc b/ash/shell.cc
index b2f63fa4420a45687047bcd0600a84869a4c01ee..11d4824744a0042a5e8434e81c712093ca46a212 100644
--- a/ash/shell.cc
+++ b/ash/shell.cc
@@ -291,8 +291,14 @@ void Shell::Init() {
partial_screenshot_filter_.reset(new internal::PartialScreenshotEventFilter);
AddRootWindowEventFilter(partial_screenshot_filter_.get());
- // InputMethodEventFilter must be added next to PartialScreenshot
- // since it has the higher priority.
+ // Then AcceleratorFilter and InputMethodEventFilter must be added (in this
+ // order) since they have the second highest priority.
+ DCHECK_EQ(1U, GetRootWindowEventFilterCount());
+#if !defined(OS_MACOSX)
+ accelerator_filter_.reset(new internal::AcceleratorFilter);
+ AddRootWindowEventFilter(accelerator_filter_.get());
+ DCHECK_EQ(2U, GetRootWindowEventFilterCount());
+#endif
input_method_filter_.reset(new internal::InputMethodEventFilter);
AddRootWindowEventFilter(input_method_filter_.get());
@@ -355,11 +361,6 @@ void Shell::Init() {
visibility_controller_.reset(new internal::VisibilityController);
aura::client::SetVisibilityClient(visibility_controller_.get());
-#if !defined(OS_MACOSX)
- accelerator_filter_.reset(new internal::AcceleratorFilter);
- AddRootWindowEventFilter(accelerator_filter_.get());
-#endif
-
tooltip_controller_.reset(new internal::TooltipController);
AddRootWindowEventFilter(tooltip_controller_.get());
aura::client::SetTooltipClient(tooltip_controller_.get());
« no previous file with comments | « ash/ime_control_delegate.h ('k') | ui/base/accelerators/accelerator.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698