Add more targets to GN check.

Add more targets to GN check.

Fix errors. Most of the problems were in net. Moves CreateAndConnectStreamForTesting's declaration to the header corresponding to the file it's implemented in.

Adds the other directories that don't pass yet to the list commented out so
it's easier to see what's still left.

TBR=armansito@chromium.org

Committed: https://crrev.com/bc44c0a95e9904154e2af47fb2dba8c37e169a13
Cr-Commit-Position: refs/heads/master@{#317425}

[brettw, 2015-02-19 23:52:24]

brettw@chromium.org changed reviewers:
+ dpranke@chromium.org, rsleevi@chromium.org

[brettw, 2015-02-19 23:52:25]

rsleevi: net/* I'm not sure if all the deps I added are OK, or whether the
includes the checker found are bad.

dirk: The rest.

[Ryan Sleevi, 2015-02-19 23:54:35]

//net LGTM

[brettw, 2015-02-20 00:33:11]

New patchsets have been uploaded after l-g-t-m from rsleevi@chromium.org

[Ryan Sleevi, 2015-02-20 00:34:10]

Why the move of the function? Could you explain more there?

[brettw, 2015-02-20 00:34:40]

Ryan: please take another look. The previous patch had a linker failure. The
thing causing this is that the function was declared in a test header, but
implemented (and called by) non-test files. This new patch just moves the
declaration of CreateAndConnectStreamForTesting to the .h file corresponding to
the .cc file it's implemented in.

[Ryan Sleevi, 2015-02-20 00:34:52]

On 2015/02/20 00:34:10, Ryan Sleevi wrote:
> Why the move of the function? Could you explain more there?

Ack, nevermind. I see it was already implemented in websocket_stream.cc to begin
with.

Still LGTM.

[Dirk Pranke, 2015-02-20 00:40:12]

lgtm except for the one comment ...

https://codereview.chromium.org/936953004/diff/40001/skia/BUILD.gn
File skia/BUILD.gn (right):

https://codereview.chromium.org/936953004/diff/40001/skia/BUILD.gn#newcode630
skia/BUILD.gn:630: "//cc:test_support",
This seems a bit odd; skia depends on cc ?

[brettw, 2015-02-20 00:48:16]

New patchsets have been uploaded after l-g-t-m from
rsleevi@chromium.org,dpranke@chromium.org

[brettw, 2015-02-20 00:53:43]

https://codereview.chromium.org/936953004/diff/40001/skia/BUILD.gn
File skia/BUILD.gn (right):

https://codereview.chromium.org/936953004/diff/40001/skia/BUILD.gn#newcode630
skia/BUILD.gn:630: "//cc:test_support",
On 2015/02/20 00:40:12, Dirk Pranke wrote:
> This seems a bit odd; skia depends on cc ?

Yes, the pixel_ref_utils_unittest uses some helper functions. I'll add a TODO.

[brettw, 2015-02-20 00:53:46]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2015-02-20 00:54:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/936953004/80001

[commit-bot: I haz the power, 2015-02-20 01:10:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-20 01:10:05]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)

[brettw, 2015-02-20 18:44:17]

I had to remove base and net on Android. I need to make some fixes to the
checker to handle these cases.

[brettw, 2015-02-20 18:44:30]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2015-02-20 18:45:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/936953004/100001

[commit-bot: I haz the power, 2015-02-20 19:05:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-20 19:05:47]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[brettw, 2015-02-20 21:01:19]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2015-02-20 21:01:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/936953004/120001

[commit-bot: I haz the power, 2015-02-20 21:13:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-20 21:13:08]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[brettw, 2015-02-20 22:26:36]

brettw@chromium.org changed reviewers:
+ armansito@chromium.org

[brettw, 2015-02-20 22:26:47]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2015-02-20 22:27:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/936953004/120001

[commit-bot: I haz the power, 2015-02-20 22:30:48]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2015-02-20 22:31:48]

Patchset 7 (id:??) landed as
https://crrev.com/bc44c0a95e9904154e2af47fb2dba8c37e169a13
Cr-Commit-Position: refs/heads/master@{#317425}

[hichris123, 2015-02-21 03:07:53]

Win8 GN started failing GN check starting with this build:
http://build.chromium.org/p/chromium.win/builders/Win8%20GN/builds/4937. Could
this CL have caused it?

[hiroshige, 2015-02-23 03:40:17]

Created https://crbug.com/460828

[binjin, 2015-02-23 11:59:10]

binjin@chromium.org changed reviewers:
+ binjin@chromium.org

[binjin, 2015-02-23 11:59:11]

I created a CL that partially revert this one.

https://codereview.chromium.org/948763003/