Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Unified Diff: .gn

Issue 936953004: Add more targets to GN check. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/config/android/rules.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: .gn
diff --git a/.gn b/.gn
index 1429a87ac7628e0abb0596a84a86ff947aea1acf..a8b55e2c7a85e12ee664723af4f6db385d201928 100644
--- a/.gn
+++ b/.gn
@@ -15,10 +15,60 @@ secondary_source = "//build/secondary/"
# their includes checked for proper dependencies when you run either
# "gn check" or "gn gen --check".
check_targets = [
- # Requires GN binary >= 314794 and to mark the "...__generate_enum" action in
- # build/config/android/rules.gni "java_cpp_enum" template with
- # check_includes = false.
- #"//base/*",
+ #"//apps/*", # Medium-hard.
+ #"//ash/*", # Medium-hard.
+ #"//base/*", # Needs GN binary changes to work on Android.
+ "//blink/*",
+ "//breakpad/*",
+ "//build/*",
"//cc/*",
+
+ #"//chrome/*", # Epic number of errors.
+ "//chromecast/*",
+ "//chrome_elf/*",
+ "//cloud_print/*",
+
+ #"//components/*", # Lots of errors.
+ #"//content/*", # A whole lot of errors.
+ "//courgette/*",
+ "//crypto/*",
+ "//data/*",
+ "//dbus/*",
+ "//device/*",
+
+ #"//extensions/*", # Lots of errors.
+ #"//gin/*", # Easy.
+ #"//google_apis/*", # Easy.
+ "//google_update/*",
+
+ #"//gpu/*", # Lots of errors.
+ #"//ios/*",
"//ipc/*",
+
+ #"//jingle/*",
+ #"//media/*", # Lots of errors.
+ #"//mojo/*",
+ #"//native_client/*",
+ #"//net/*", # Needs GN binary changes to work on Android.
+
+ #"//pdf/*", # Medium-hard.
+ #"//ppapi/*", # Lots of errors.
+ "//printing/*",
+
+ #"//remoting/*", # Medium-hard.
+ #"//rlz/*", # Needs checking on Windows.
+ #"//sandbox/*", # Medium-hard.
+ "//sdch/*",
+ "//skia/*",
+ "//sql/*",
+ "//storage/*",
+ "//sync/*",
+ "//testing/*",
+
+ #"//third_party/*", # May not ever want this.
+ "//tools/*",
+
+ #"//ui/*", # Just a few problems.
+ "//url/*",
+ "//v8/*",
]
« no previous file with comments | « no previous file | build/config/android/rules.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698