build/config/android/rules.gni - Issue 936953004: Add more targets to GN check.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/config/android/rules.gni

Issue 936953004: Add more targets to GN check. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/config/android/rules.gni

diff --git a/build/config/android/rules.gni b/build/config/android/rules.gni

index 33dfa37e6c2a33f3a31da77494c5a227540b2976..8582d47faeb49f2fec1807b552387619c3c977f3 100644

--- a/build/config/android/rules.gni

+++ b/build/config/android/rules.gni

@@ -346,9 +346,7 @@ template("java_cpp_enum") {

action("${target_name}__generate_enum") {

# The sources aren't compiled so don't check their dependencies.

- # TODO(brettw) uncomment after GN binary rolled pas 314974 (which added

- # support for this value on actions).

- #check_includes = false

+ check_includes = false

sources = invoker.sources

script = "//build/android/gyp/java_cpp_enum.py"

« no previous file with comments | « .gn ('k') | build/config/linux/BUILD.gn » ('j') | no next file with comments »