content/browser/aura/software_output_device_win.h - Issue 93663004: [#2] Pass gfx structs by const ref (gfx::Rect, gfx::RectF)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/aura/software_output_device_win.h

Issue 93663004: [#2] Pass gfx structs by const ref (gfx::Rect, gfx::RectF) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase to ToT, fix builds on non-linux platforms! Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/aura/software_output_device_win.h

diff --git a/content/browser/aura/software_output_device_win.h b/content/browser/aura/software_output_device_win.h

index 9c0655b6f67a40f454b64a41f7c960d09dc20bb0..5518de2f0de9ee55f5a31548c91b75a9f737d613 100644

--- a/content/browser/aura/software_output_device_win.h

+++ b/content/browser/aura/software_output_device_win.h

@@ -26,9 +26,9 @@ class SoftwareOutputDeviceWin : public cc::SoftwareOutputDevice {

virtual ~SoftwareOutputDeviceWin();

virtual void Resize(gfx::Size viewport_size) OVERRIDE;

- virtual SkCanvas* BeginPaint(gfx::Rect damage_rect) OVERRIDE;

+ virtual SkCanvas* BeginPaint(const gfx::Rect& damage_rect) OVERRIDE;

virtual void EndPaint(cc::SoftwareFrameData* frame_data) OVERRIDE;

- virtual void CopyToBitmap(gfx::Rect rect, SkBitmap* output) OVERRIDE;

+ virtual void CopyToBitmap(const gfx::Rect& rect, SkBitmap* output) OVERRIDE;

private:

HWND hwnd_;

« no previous file with comments | « content/browser/aura/software_output_device_ozone.cc ('k') | content/browser/aura/software_output_device_win.cc » ('j') | no next file with comments »