Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Unified Diff: content/browser/aura/software_output_device_win.cc

Issue 93663004: [#2] Pass gfx structs by const ref (gfx::Rect, gfx::RectF) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase to ToT, fix builds on non-linux platforms! Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/aura/software_output_device_win.cc
diff --git a/content/browser/aura/software_output_device_win.cc b/content/browser/aura/software_output_device_win.cc
index f8d6d9b6d70339bfa178b85c7a82039b31538695..b6e9d78a051d1a795dde066f5362c8adf9bcf94d 100644
--- a/content/browser/aura/software_output_device_win.cc
+++ b/content/browser/aura/software_output_device_win.cc
@@ -42,7 +42,7 @@ void SoftwareOutputDeviceWin::Resize(gfx::Size viewport_size) {
&bitmap_info_.bmiHeader);
}
-SkCanvas* SoftwareOutputDeviceWin::BeginPaint(gfx::Rect damage_rect) {
+SkCanvas* SoftwareOutputDeviceWin::BeginPaint(const gfx::Rect& damage_rect) {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
DCHECK(contents_);
@@ -93,7 +93,7 @@ void SoftwareOutputDeviceWin::EndPaint(cc::SoftwareFrameData* frame_data) {
}
void SoftwareOutputDeviceWin::CopyToBitmap(
- gfx::Rect rect, SkBitmap* output) {
+ const gfx::Rect& rect, SkBitmap* output) {
DCHECK(contents_);
SkBaseDevice* device = contents_->sk_canvas()->getDevice();
const SkBitmap& bitmap = device->accessBitmap(false);
« no previous file with comments | « content/browser/aura/software_output_device_win.h ('k') | content/renderer/gpu/compositor_software_output_device.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698