content/browser/aura/software_output_device_ozone.cc - Issue 93663004: [#2] Pass gfx structs by const ref (gfx::Rect, gfx::RectF)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/aura/software_output_device_ozone.cc

Issue 93663004: [#2] Pass gfx structs by const ref (gfx::Rect, gfx::RectF) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase to ToT, fix builds on non-linux platforms! Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/aura/software_output_device_ozone.cc

diff --git a/content/browser/aura/software_output_device_ozone.cc b/content/browser/aura/software_output_device_ozone.cc

index 1641f0f667bac790de7644d35103886b6f3821de..29b322e818054e41ffd3e6ff6e29210cfd4e7da9 100644

--- a/content/browser/aura/software_output_device_ozone.cc

+++ b/content/browser/aura/software_output_device_ozone.cc

@@ -45,7 +45,7 @@ void SoftwareOutputDeviceOzone::Resize(gfx::Size viewport_size) {

device_ = skia::SharePtr(canvas_->getDevice());

}

-SkCanvas* SoftwareOutputDeviceOzone::BeginPaint(gfx::Rect damage_rect) {

+SkCanvas* SoftwareOutputDeviceOzone::BeginPaint(const gfx::Rect& damage_rect) {

DCHECK(gfx::Rect(viewport_size_).Contains(damage_rect));

canvas_->clipRect(gfx::RectToSkRect(damage_rect), SkRegion::kReplace_Op);

« no previous file with comments | « content/browser/aura/software_output_device_ozone.h ('k') | content/browser/aura/software_output_device_win.h » ('j') | no next file with comments »