cc/layers/scrollbar_layer_impl_base.h - Issue 93663004: [#2] Pass gfx structs by const ref (gfx::Rect, gfx::RectF)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/layers/scrollbar_layer_impl_base.h

Issue 93663004: [#2] Pass gfx structs by const ref (gfx::Rect, gfx::RectF) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase to ToT, fix builds on non-linux platforms! Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/layers/scrollbar_layer_impl_base.h

diff --git a/cc/layers/scrollbar_layer_impl_base.h b/cc/layers/scrollbar_layer_impl_base.h

index f75808e66edd1297507c2ca1265a771e2221bd53..6bba7495d730bf0020da1e2350712e369abfcb2f 100644

--- a/cc/layers/scrollbar_layer_impl_base.h

+++ b/cc/layers/scrollbar_layer_impl_base.h

@@ -53,7 +53,7 @@ class CC_EXPORT ScrollbarLayerImplBase : public LayerImpl {

bool is_left_side_vertical_scrollbar);

virtual ~ScrollbarLayerImplBase() {}

- gfx::Rect ScrollbarLayerRectToContentRect(gfx::RectF layer_rect) const;

+ gfx::Rect ScrollbarLayerRectToContentRect(const gfx::RectF& layer_rect) const;

float visible_to_total_length_ratio() const {

return visible_to_total_length_ratio_;

« no previous file with comments | « cc/layers/render_surface_impl.cc ('k') | cc/layers/scrollbar_layer_impl_base.cc » ('j') | no next file with comments »