cc/layers/scrollbar_layer_impl_base.cc - Issue 93663004: [#2] Pass gfx structs by const ref (gfx::Rect, gfx::RectF)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/layers/scrollbar_layer_impl_base.cc

Issue 93663004: [#2] Pass gfx structs by const ref (gfx::Rect, gfx::RectF) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase to ToT, fix builds on non-linux platforms! Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/layers/scrollbar_layer_impl_base.cc

diff --git a/cc/layers/scrollbar_layer_impl_base.cc b/cc/layers/scrollbar_layer_impl_base.cc

index e9b9569e03ebf499850b1ee3ce3159aea4736382..55f46f51d846fe0fe074735abd315c6007dd49f7 100644

--- a/cc/layers/scrollbar_layer_impl_base.cc

+++ b/cc/layers/scrollbar_layer_impl_base.cc

@@ -35,7 +35,7 @@ ScrollbarLayerImplBase* ScrollbarLayerImplBase::ToScrollbarLayer() {

}

gfx::Rect ScrollbarLayerImplBase::ScrollbarLayerRectToContentRect(

- gfx::RectF layer_rect) const {

+ const gfx::RectF& layer_rect) const {

// Don't intersect with the bounds as in LayerRectToContentRect() because

// layer_rect here might be in coordinates of the containing layer.

gfx::RectF content_rect = gfx::ScaleRect(layer_rect,

« no previous file with comments | « cc/layers/scrollbar_layer_impl_base.h ('k') | cc/layers/scrollbar_theme_painter.h » ('j') | no next file with comments »