cc/layers/render_surface_impl.cc - Issue 93663004: [#2] Pass gfx structs by const ref (gfx::Rect, gfx::RectF)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/layers/render_surface_impl.cc

Issue 93663004: [#2] Pass gfx structs by const ref (gfx::Rect, gfx::RectF) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase to ToT, fix builds on non-linux platforms! Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/layers/render_surface_impl.cc

diff --git a/cc/layers/render_surface_impl.cc b/cc/layers/render_surface_impl.cc

index a8336bcaf4f8510b036996ebfa7d2f4fce70d8e3..c118f0e406b5df7062fd060e5a7c9d5700700771 100644

--- a/cc/layers/render_surface_impl.cc

+++ b/cc/layers/render_surface_impl.cc

@@ -64,7 +64,7 @@ int RenderSurfaceImpl::OwningLayerId() const {

}

-void RenderSurfaceImpl::SetClipRect(gfx::Rect clip_rect) {

+void RenderSurfaceImpl::SetClipRect(const gfx::Rect& clip_rect) {

if (clip_rect_ == clip_rect)

return;

@@ -76,7 +76,7 @@ bool RenderSurfaceImpl::ContentsChanged() const {

return !damage_tracker_->current_damage_rect().IsEmpty();

}

-void RenderSurfaceImpl::SetContentRect(gfx::Rect content_rect) {

+void RenderSurfaceImpl::SetContentRect(const gfx::Rect& content_rect) {

if (content_rect_ == content_rect)

return;

« no previous file with comments | « cc/layers/render_surface_impl.h ('k') | cc/layers/scrollbar_layer_impl_base.h » ('j') | no next file with comments »