Issue 936563002: Make tests/clipping/canvas-rounded-corners.sky actually run.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 936563002: Make tests/clipping/canvas-rounded-corners.sky actually run. (Closed)

Created:
5 years, 10 months ago by eseidel

Modified:
5 years, 10 months ago

Reviewers:
abarth-chromium, ojan

CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Make tests/clipping/canvas-rounded-corners.sky actually run. Because we dump dart errors to LOG(ERROR) (stderr) instead of console.log / stdout, tests with dart errors just "pass" and we don't notice they're not running. This was the case with canvas-rounded-corners.sky. I don't think this test actually passes yet, despite it claiming to, but I at least have made it run and not crash. Required me commenting out a ton of CanvasRenderingContext2D, but that's fine, it wasn't actually working and it's better to have it be compiling valid dart. R=abarth@chromium.org, ojan@chromium.org BUG= Committed: https://chromium.googlesource.com/external/mojo/+/e869e7d1d3dc8827c34894ed8a53c81bf27d0736

Patch Set 1 #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+41 lines, -31 lines)			Patch
M	sky/engine/bindings/scripts/dart_interface.py	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	sky/engine/core/css/CSS.idl	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	sky/engine/core/html/canvas/CanvasRenderingContext2D.idl	View	5 chunks	+30 lines, -28 lines	0 comments	Download
M	sky/engine/core/script/dart_controller.cc	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	sky/tests/clipping/canvas-rounded-corners.sky	View	1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

eseidel

5 years, 10 months ago (2015-02-17 20:25:19 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
e869e7d1d3dc8827c34894ed8a53c81bf27d0736 (presubmit successful).

Expand Messages | Collapse Messages