sky/engine/core/script/dart_controller.cc - Issue 936563002: Make tests/clipping/canvas-rounded-corners.sky actually run.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/script/dart_controller.cc

Issue 936563002: Make tests/clipping/canvas-rounded-corners.sky actually run. (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/core/script/dart_controller.cc

diff --git a/sky/engine/core/script/dart_controller.cc b/sky/engine/core/script/dart_controller.cc

index 73d410f6dd14846a584fac37b39bf5ce02e94fcb..a46fcc256a4803d8cfb571070d373c630f121df7 100644

--- a/sky/engine/core/script/dart_controller.cc

+++ b/sky/engine/core/script/dart_controller.cc

@@ -100,7 +100,9 @@ void DartController::ExecuteModule(RefPtr<AbstractModule> module) {

DCHECK(Dart_CurrentIsolate() == dart_state()->isolate());

DartApiScope dart_api_scope;

- LogIfError(Dart_FinalizeLoading(true));

+ // Don't continue if we failed to load the module.

+ if (LogIfError(Dart_FinalizeLoading(true)))

+ return;

Dart_Handle library = module->library()->dart_value();

const char* name = module->isApplication() ? "main" : "init";

Dart_Handle closure_name = Dart_NewStringFromCString(name);