Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 936103003: Roll GN binaries to #317120 for the cpu_arch changes (Closed)

Created:
5 years, 10 months ago by Dirk Pranke
Modified:
5 years, 10 months ago
Reviewers:
brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@gn_cpu_arch_changes
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll GN binaries to #317120 for the cpu_arch changes The newest version of GN replaces the 'cpu_arch' and 'os' variables with 'current_cpu', 'target_cpu', 'current_os', and 'target_os', and also replaces 'build_cpu' with 'host_cpu', and 'build_os' with 'host_os'. The roll also picks up the change to add a new 'gn clean' command, some absolute path handling fixes, a check_includes fix for action_foreach(), and some minor internal fixes. This patch also updates the build config files to accommodate the GN changes in a backwards-compatible manner, i.e., the configs now will set cpu_arch and os correctly in the right contexts. They will also allow the users to continue to set os= and cpu_arch= in an args file, so no user builds (or bots) will break. Once all of the bots and all of the build files have been updated to refer to the new variables instead of the old ones, we can drop the backwards-compatible versions. TBR=brettw@chromium.org BUG=344767 CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg Committed: https://crrev.com/7ee02bed35766535521c8e1f072b98cbf9eef53d Cr-Commit-Position: refs/heads/master@{#317186}

Patch Set 1 #

Patch Set 2 : clean up #

Patch Set 3 : merge to #316930 #

Patch Set 4 : add DEPS change #

Patch Set 5 : fix android_gcc_toolchain() invocations for new toolchains #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -23 lines) Patch
M DEPS View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M build/config/BUILDCONFIG.gn View 1 2 2 chunks +44 lines, -0 lines 0 comments Download
M build/toolchain/android/BUILD.gn View 1 2 3 4 7 chunks +7 lines, -7 lines 0 comments Download
M build/toolchain/cros/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M build/toolchain/gcc_toolchain.gni View 1 2 chunks +15 lines, -4 lines 0 comments Download
M build/toolchain/linux/BUILD.gn View 6 chunks +6 lines, -6 lines 0 comments Download
M build/toolchain/mac/BUILD.gn View 1 2 1 chunk +4 lines, -1 line 0 comments Download
M build/toolchain/win/BUILD.gn View 2 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
Dirk Pranke
Please take a look. This patch depends on the changes to GN in https://codereview.chromium.org/914873002/ , ...
5 years, 10 months ago (2015-02-19 00:16:21 UTC) #2
brettw
lgtm
5 years, 10 months ago (2015-02-19 21:47:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/936103003/60001
5 years, 10 months ago (2015-02-19 22:04:01 UTC) #6
commit-bot: I haz the power
Transient error: Invalid delimiter in "android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel,win8_chromium_gn_rel,win8_chromium_gn_dbg,mac_chromium_gn_rel,mac_chromium_gn_dbg": Correct syntax is "tryserver:bot1,bot2;tryserver2:bot3,bot4;".
5 years, 10 months ago (2015-02-19 22:04:03 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/936103003/60001
5 years, 10 months ago (2015-02-19 22:07:14 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_dbg/builds/44399) android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 10 months ago (2015-02-19 22:14:57 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/936103003/80001
5 years, 10 months ago (2015-02-19 22:43:49 UTC) #14
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 10 months ago (2015-02-20 00:16:27 UTC) #15
commit-bot: I haz the power
5 years, 10 months ago (2015-02-20 00:17:08 UTC) #16
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/7ee02bed35766535521c8e1f072b98cbf9eef53d
Cr-Commit-Position: refs/heads/master@{#317186}

Powered by Google App Engine
This is Rietveld 408576698