Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 935253002: BlinkGCPlugin: Fix base class trace call detection in traceImpl(). (Closed)

Created:
5 years, 10 months ago by Yuta Kitamura
Modified:
5 years, 10 months ago
Reviewers:
kouhei (in TOK)
CC:
chromium-reviews, zerny-chromium, oilpan-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

BlinkGCPlugin: Fix base class trace call detection in traceImpl(). Existing code has assumed a trace function call delegating to a base class has the same name as the name of the function where the trace call is written (e.g. Base::trace(visitor) in Derived::trace(), and Base::traceAfterDispatch(visitor) in Derived::traceAfterDispatch()). After the introduction of traceImpl(), however, this is no longer true. This patch fixes this issue. BUG=none R=kouhei@chromium.org CC=zerny@chromium.org, oilpan-reviews@chromium.org Committed: https://crrev.com/d8c277946ff3cb54a256a77c38d60373f14dee29 Cr-Commit-Position: refs/heads/master@{#317026}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -13 lines) Patch
M tools/clang/blink_gc_plugin/BlinkGCPlugin.cpp View 1 chunk +11 lines, -6 lines 0 comments Download
M tools/clang/blink_gc_plugin/tests/traceimpl.h View 2 chunks +30 lines, -3 lines 0 comments Download
M tools/clang/blink_gc_plugin/tests/traceimpl.cpp View 1 chunk +12 lines, -1 line 0 comments Download
M tools/clang/blink_gc_plugin/tests/traceimpl_error.h View 2 chunks +23 lines, -1 line 0 comments Download
M tools/clang/blink_gc_plugin/tests/traceimpl_error.cpp View 1 chunk +10 lines, -0 lines 0 comments Download
M tools/clang/blink_gc_plugin/tests/traceimpl_error.txt View 1 chunk +8 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Yuta Kitamura
5 years, 10 months ago (2015-02-19 05:13:36 UTC) #1
kouhei (in TOK)
lgtm
5 years, 10 months ago (2015-02-19 10:59:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/935253002/1
5 years, 10 months ago (2015-02-19 11:00:24 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-19 11:03:45 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-19 11:04:28 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d8c277946ff3cb54a256a77c38d60373f14dee29
Cr-Commit-Position: refs/heads/master@{#317026}

Powered by Google App Engine
This is Rietveld 408576698