Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: tools/clang/blink_gc_plugin/tests/traceimpl_error.txt

Issue 935253002: BlinkGCPlugin: Fix base class trace call detection in traceImpl(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/clang/blink_gc_plugin/tests/traceimpl_error.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/clang/blink_gc_plugin/tests/traceimpl_error.txt
diff --git a/tools/clang/blink_gc_plugin/tests/traceimpl_error.txt b/tools/clang/blink_gc_plugin/tests/traceimpl_error.txt
index e2471beaeeb74b3f8e68e6ba38a454ec3aea555b..070b02961c0953d3fc2ba8674ec4e158fa1471a1 100644
--- a/tools/clang/blink_gc_plugin/tests/traceimpl_error.txt
+++ b/tools/clang/blink_gc_plugin/tests/traceimpl_error.txt
@@ -5,10 +5,16 @@ In file included from traceimpl_error.cpp:5:
./traceimpl_error.h:28:3: note: [blink-gc] Untraced field 'x_' declared here:
Member<X> x_;
^
+./traceimpl_error.h:53:3: warning: [blink-gc] Base class 'Base' of derived class 'TraceImplInlineWithUntracedBase' requires tracing.
+ void traceImpl(VisitorDispatcher visitor) {
+ ^
traceimpl_error.cpp:14:1: warning: [blink-gc] Class 'TraceImplExternWithUntracedMember' has untraced fields that require tracing.
inline void TraceImplExternWithUntracedMember::traceImpl(
^
-./traceimpl_error.h:41:3: note: [blink-gc] Untraced field 'x_' declared here:
+./traceimpl_error.h:40:3: note: [blink-gc] Untraced field 'x_' declared here:
Member<X> x_;
^
-2 warnings generated.
+traceimpl_error.cpp:24:1: warning: [blink-gc] Base class 'Base' of derived class 'TraceImplExternWithUntracedBase' requires tracing.
+inline void TraceImplExternWithUntracedBase::traceImpl(
+^
+4 warnings generated.
« no previous file with comments | « tools/clang/blink_gc_plugin/tests/traceimpl_error.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698