Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Unified Diff: tools/clang/blink_gc_plugin/tests/traceimpl_error.cpp

Issue 935253002: BlinkGCPlugin: Fix base class trace call detection in traceImpl(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/clang/blink_gc_plugin/tests/traceimpl_error.cpp
diff --git a/tools/clang/blink_gc_plugin/tests/traceimpl_error.cpp b/tools/clang/blink_gc_plugin/tests/traceimpl_error.cpp
index e6ab1b1e673b355d54d468e7428aa14fe220803c..041c565e54d45f6651d4c536d09b88f3cfef50f1 100644
--- a/tools/clang/blink_gc_plugin/tests/traceimpl_error.cpp
+++ b/tools/clang/blink_gc_plugin/tests/traceimpl_error.cpp
@@ -16,4 +16,14 @@ inline void TraceImplExternWithUntracedMember::traceImpl(
// Should get a warning as well.
}
+void TraceImplExternWithUntracedBase::trace(Visitor* visitor) {
+ traceImpl(visitor);
+}
+
+template <typename VisitorDispatcher>
+inline void TraceImplExternWithUntracedBase::traceImpl(
+ VisitorDispatcher visitor) {
+ // Ditto.
+}
+
}
« no previous file with comments | « tools/clang/blink_gc_plugin/tests/traceimpl_error.h ('k') | tools/clang/blink_gc_plugin/tests/traceimpl_error.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698