build/common.gypi - Issue 935083003: Move strict-virtual-specifiers flag to be specified in plugin_flags.sh

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/common.gypi

Issue 935083003: Move strict-virtual-specifiers flag to be specified in plugin_flags.sh (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Moar Xclang Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/common.gypi

diff --git a/build/common.gypi b/build/common.gypi

index 3a071c8b760483be3aadd8302aa235efcd6d1f25..93da26f23dfb1f46f93d287136ccc1940cc133bd 100644

--- a/build/common.gypi

+++ b/build/common.gypi

@@ -2144,18 +2144,6 @@

'clang_chrome_plugins_flags': [

'<!@(<(DEPTH)/tools/clang/scripts/plugin_flags.sh)'

- 'conditions': [

- # TODO(dcheng): https://crbug.com/417463 -- work to enable this flag

- # on all platforms is currently underway.

- ['OS=="android" or OS=="linux" or OS=="mac" or OS=="ios"', {

- 'clang_chrome_plugins_flags': [

- '-Xclang',

- '-plugin-arg-find-bad-constructs',

- '-Xclang',

- 'strict-virtual-specifiers',

- ],

- }],

- ],

}],

['asan==1 or msan==1 or lsan==1 or tsan==1', {

'clang%': 1,

« no previous file with comments | « no previous file | tools/clang/scripts/plugin_flags.sh » ('j') | no next file with comments »