tools/clang/scripts/plugin_flags.sh - Issue 935083003: Move strict-virtual-specifiers flag to be specified in plugin_flags.sh

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/clang/scripts/plugin_flags.sh

Issue 935083003: Move strict-virtual-specifiers flag to be specified in plugin_flags.sh (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 #!/usr/bin/env bash	1 #!/usr/bin/env bash

2 # Copyright (c) 2012 The Chromium Authors. All rights reserved.	2 # Copyright (c) 2012 The Chromium Authors. All rights reserved.

3 # Use of this source code is governed by a BSD-style license that can be	3 # Use of this source code is governed by a BSD-style license that can be

4 # found in the LICENSE file.	4 # found in the LICENSE file.

5	5

6 # This script returns the flags that should be used when GYP_DEFINES contains	6 # This script returns the flags that should be used when GYP_DEFINES contains

7 # clang_use_chrome_plugins. The flags are stored in a script so that they can	7 # clang_use_chrome_plugins. The flags are stored in a script so that they can

8 # be changed on the bots without requiring a master restart.	8 # be changed on the bots without requiring a master restart.

9	9

10 SRC_ABS_DIR=$(cd $(dirname $0)/../../.. && echo $PWD)	10 SRC_ABS_DIR=$(cd $(dirname $0)/../../.. && echo $PWD)

11 CLANG_LIB_PATH=$SRC_ABS_DIR/third_party/llvm-build/Release+Asserts/lib	11 CLANG_LIB_PATH=$SRC_ABS_DIR/third_party/llvm-build/Release+Asserts/lib

12	12

13 if uname -s \| grep -q Darwin; then	13 if uname -s \| grep -q Darwin; then

14 LIBSUFFIX=dylib	14 LIBSUFFIX=dylib

15 else	15 else

16 LIBSUFFIX=so	16 LIBSUFFIX=so

17 fi	17 fi

18	18

19 echo -Xclang -load -Xclang $CLANG_LIB_PATH/libFindBadConstructs.$LIBSUFFIX \	19 echo -Xclang -load -Xclang $CLANG_LIB_PATH/libFindBadConstructs.$LIBSUFFIX \

20 -Xclang -add-plugin -Xclang find-bad-constructs -Xclang \	20 -Xclang -add-plugin -Xclang find-bad-constructs -Xclang \

21 -plugin-arg-find-bad-constructs -Xclang check-weak-ptr-factory-order	21 -plugin-arg-find-bad-constructs -Xclang check-weak-ptr-factory-order

	22 -plugin-arg-find-bad-constructs -Xclang strict-virtual-specifiers
	hans 2015/02/18 18:25:51 I think this needs more -Xclang? I think this needs more -Xclang? dcheng 2015/02/18 19:33:06 Yeah, I had another typo too. Fixed. Show quoted text On 2015/02/18 18:25:51, hans wrote: > I think this needs more -Xclang? Yeah, I had another typo too. Fixed.
OLD	NEW

« no previous file with comments | « build/common.gypi ('k') | no next file » | no next file with comments »