Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 934863003: Autofill: Fix showing predictions for synthetic forms. (Closed)

Created:
5 years, 10 months ago by Lei Zhang
Modified:
5 years, 10 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews, darin-cc_chromium.org, jam, rouslan+autofillwatch_chromium.org, browser-components-watch_chromium.org, estade+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Autofill: Fix showing predictions for synthetic forms. Also convert FormStructure::GetFieldTypePredictions() to return its data instead of using an out parameter. Committed: https://crrev.com/34855a14235a5a533d8d98d1ba53175f54703b98 Cr-Commit-Position: refs/heads/master@{#316938}

Patch Set 1 #

Total comments: 3

Patch Set 2 : rebase #

Patch Set 3 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -16 lines) Patch
M components/autofill/content/browser/content_autofill_driver.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/autofill/content/browser/content_autofill_driver_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M components/autofill/core/browser/form_structure.h View 1 2 1 chunk +4 lines, -5 lines 0 comments Download
M components/autofill/core/browser/form_structure.cc View 1 2 2 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
Lei Zhang
5 years, 10 months ago (2015-02-18 02:20:28 UTC) #2
Lei Zhang
https://codereview.chromium.org/934863003/diff/1/components/autofill/core/browser/form_structure.cc File components/autofill/core/browser/form_structure.cc (right): https://codereview.chromium.org/934863003/diff/1/components/autofill/core/browser/form_structure.cc#newcode637 components/autofill/core/browser/form_structure.cc:637: form.data.is_form_tag = form_structure->is_form_tag(); I suppose we don't need is_form_tag() ...
5 years, 10 months ago (2015-02-18 03:23:20 UTC) #3
Evan Stade
https://codereview.chromium.org/934863003/diff/1/components/autofill/core/browser/form_structure.cc File components/autofill/core/browser/form_structure.cc (right): https://codereview.chromium.org/934863003/diff/1/components/autofill/core/browser/form_structure.cc#newcode637 components/autofill/core/browser/form_structure.cc:637: form.data.is_form_tag = form_structure->is_form_tag(); On 2015/02/18 03:23:20, Lei Zhang wrote: ...
5 years, 10 months ago (2015-02-18 22:42:33 UTC) #4
Lei Zhang
https://codereview.chromium.org/934863003/diff/1/components/autofill/core/browser/form_structure.cc File components/autofill/core/browser/form_structure.cc (right): https://codereview.chromium.org/934863003/diff/1/components/autofill/core/browser/form_structure.cc#newcode637 components/autofill/core/browser/form_structure.cc:637: form.data.is_form_tag = form_structure->is_form_tag(); On 2015/02/18 22:42:33, Evan Stade wrote: ...
5 years, 10 months ago (2015-02-18 23:07:18 UTC) #5
Evan Stade
lgtm
5 years, 10 months ago (2015-02-18 23:11:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/934863003/40001
5 years, 10 months ago (2015-02-18 23:13:45 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-19 00:47:06 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-19 00:47:46 UTC) #10
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/34855a14235a5a533d8d98d1ba53175f54703b98
Cr-Commit-Position: refs/heads/master@{#316938}

Powered by Google App Engine
This is Rietveld 408576698