components/autofill/core/browser/form_structure.h - Issue 934863003: Autofill: Fix showing predictions for synthetic forms.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/form_structure.h

Issue 934863003: Autofill: Fix showing predictions for synthetic forms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nit Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/content/browser/content_autofill_driver_unittest.cc ('k') | components/autofill/core/browser/form_structure.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/form_structure.h

diff --git a/components/autofill/core/browser/form_structure.h b/components/autofill/core/browser/form_structure.h

index 119117aa96df1342dbf1e3a1ec8c57b41d429c15..22347198bb3689dbb2cc3e1be28dae69d4cc47a4 100644

--- a/components/autofill/core/browser/form_structure.h

+++ b/components/autofill/core/browser/form_structure.h

@@ -76,11 +76,10 @@ class FormStructure {

static void ParseQueryResponse(const std::string& response_xml,

const std::vector<FormStructure*>& forms);

- // Fills |forms| with the details from the given |form_structures| and their

- // fields' predicted types.

- static void GetFieldTypePredictions(

- const std::vector<FormStructure*>& form_structures,

- std::vector<FormDataPredictions>* forms);

+ // Returns predictions using the details from the given |form_structures| and

+ // their fields' predicted types.

+ static std::vector<FormDataPredictions> GetFieldTypePredictions(

+ const std::vector<FormStructure*>& form_structures);

// The unique signature for this form, composed of the target url domain,

// the form name, and the form field names in a 64-bit hash.