components/autofill/content/browser/content_autofill_driver_unittest.cc - Issue 934863003: Autofill: Fix showing predictions for synthetic forms.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/content/browser/content_autofill_driver_unittest.cc

Issue 934863003: Autofill: Fix showing predictions for synthetic forms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nit Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/content/browser/content_autofill_driver.cc ('k') | components/autofill/core/browser/form_structure.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/content/browser/content_autofill_driver_unittest.cc

diff --git a/components/autofill/content/browser/content_autofill_driver_unittest.cc b/components/autofill/content/browser/content_autofill_driver_unittest.cc

index 0ade6e6a63c44b14e40fea0403160e2d35294400..c37633265f82e3afbc951886681cd25c889fe42b 100644

--- a/components/autofill/content/browser/content_autofill_driver_unittest.cc

+++ b/components/autofill/content/browser/content_autofill_driver_unittest.cc

@@ -30,7 +30,7 @@ namespace autofill {

namespace {

-const std::string kAppLocale = "en-US";

+const char kAppLocale[] = "en-US";

const AutofillManager::AutofillDownloadManagerState kDownloadState =

AutofillManager::DISABLE_AUTOFILL_DOWNLOAD_MANAGER;

@@ -272,8 +272,8 @@ TEST_F(ContentAutofillDriverTest, TypePredictionsSentToRendererWhenEnabled) {

test::CreateTestAddressFormData(&form);

FormStructure form_structure(form);

std::vector<FormStructure*> forms(1, &form_structure);

- std::vector<FormDataPredictions> expected_type_predictions;

- FormStructure::GetFieldTypePredictions(forms, &expected_type_predictions);

+ std::vector<FormDataPredictions> expected_type_predictions =

+ FormStructure::GetFieldTypePredictions(forms);

driver_->SendAutofillTypePredictionsToRenderer(forms);

std::vector<FormDataPredictions> output_type_predictions;