Ash frames: dark frames now use white caption buttons.

Ash frames: dark frames now use white caption buttons.

Also included in this change is the removal of inactive caption assets.
Instead of including these as assets, the normal assets are drawn with
20% alpha instead.

TBR=oshima
BUG=448308
Committed: https://crrev.com/cc4dc2dea6c65c7e03c560c678c2b57b4d217fa8
Cr-Commit-Position: refs/heads/master@{#316790}

[benwells, 2015-02-16 09:51:58]

benwells@chromium.org changed reviewers:
+ jamescook@chromium.org, oshima@chromium.org, pkotwicz@chromium.org

[benwells, 2015-02-16 09:52:37]

pkotwicz for ash/
jamescook for c/b/ui/views/frame
oshima for binaries / grd

[pkotwicz, 2015-02-17 18:56:43]

LGTM with comments

Why the .zip file?

https://codereview.chromium.org/934503002/diff/40001/ash/frame/caption_button...
File ash/frame/caption_buttons/frame_caption_button.cc (right):

https://codereview.chromium.org/934503002/diff/40001/ash/frame/caption_button...
ash/frame/caption_buttons/frame_caption_button.cc:174: alpha =
static_cast<int>(kInactiveIconAlpha * alpha);
Nit: alpha *=  kInactiveIconAlpha

https://codereview.chromium.org/934503002/diff/40001/ash/frame/default_header...
File ash/frame/default_header_painter.h (right):

https://codereview.chromium.org/934503002/diff/40001/ash/frame/default_header...
ash/frame/default_header_painter.h:78: // background of the frame is dark.
Nit: "caption images" -> "caption button images"

[James Cook, 2015-02-17 22:16:55]

LGTM but please address comments before landing

https://codereview.chromium.org/934503002/diff/40001/ash/frame/caption_button...
File ash/frame/caption_buttons/frame_caption_button.cc (right):

https://codereview.chromium.org/934503002/diff/40001/ash/frame/caption_button...
ash/frame/caption_buttons/frame_caption_button.cc:67: crossfade_icon_image_ =
icon_image_;
Do we still need crossfade_icon_image_? It looks like it always fades from
icon_image_ to icon_image_.

https://codereview.chromium.org/934503002/diff/40001/ash/frame/default_header...
File ash/frame/default_header_painter.cc (right):

https://codereview.chromium.org/934503002/diff/40001/ash/frame/default_header...
ash/frame/default_header_painter.cc:291: bool
DefaultHeaderPainter::ShouldUseLightImages() {
Can you add a little test for this? It would be nice to see a couple sample
colors.

[benwells, 2015-02-17 22:18:38]

https://codereview.chromium.org/934503002/diff/40001/ash/frame/caption_button...
File ash/frame/caption_buttons/frame_caption_button.cc (right):

https://codereview.chromium.org/934503002/diff/40001/ash/frame/caption_button...
ash/frame/caption_buttons/frame_caption_button.cc:67: crossfade_icon_image_ =
icon_image_;
On 2015/02/17 22:16:55, James Cook wrote:
> Do we still need crossfade_icon_image_? It looks like it always fades from
> icon_image_ to icon_image_.

I think this is still needed, as on line 70 and 75 the icon image is about to
get changed. This remembers the previous one.

[James Cook, 2015-02-17 22:20:20]

https://codereview.chromium.org/934503002/diff/40001/ash/frame/caption_button...
File ash/frame/caption_buttons/frame_caption_button.cc (right):

https://codereview.chromium.org/934503002/diff/40001/ash/frame/caption_button...
ash/frame/caption_buttons/frame_caption_button.cc:67: crossfade_icon_image_ =
icon_image_;
On 2015/02/17 22:18:38, benwells wrote:
> On 2015/02/17 22:16:55, James Cook wrote:
> > Do we still need crossfade_icon_image_? It looks like it always fades from
> > icon_image_ to icon_image_.
> 
> I think this is still needed, as on line 70 and 75 the icon image is about to
> get changed. This remembers the previous one.

Yep, my mistake.

[benwells, 2015-02-18 07:07:59]

New patchsets have been uploaded after l-g-t-m from
pkotwicz@chromium.org,jamescook@chromium.org

[benwells, 2015-02-18 07:08:46]

zip file was a mistake :/

https://codereview.chromium.org/934503002/diff/40001/ash/frame/caption_button...
File ash/frame/caption_buttons/frame_caption_button.cc (right):

https://codereview.chromium.org/934503002/diff/40001/ash/frame/caption_button...
ash/frame/caption_buttons/frame_caption_button.cc:174: alpha =
static_cast<int>(kInactiveIconAlpha * alpha);
On 2015/02/17 18:56:42, pkotwicz wrote:
> Nit: alpha *=  kInactiveIconAlpha

Done.

https://codereview.chromium.org/934503002/diff/40001/ash/frame/default_header...
File ash/frame/default_header_painter.cc (right):

https://codereview.chromium.org/934503002/diff/40001/ash/frame/default_header...
ash/frame/default_header_painter.cc:291: bool
DefaultHeaderPainter::ShouldUseLightImages() {
On 2015/02/17 22:16:55, James Cook wrote:
> Can you add a little test for this? It would be nice to see a couple sample
> colors.

Done.

[benwells, 2015-02-18 07:09:15]

As oshima is a way, and jamescook has reviewed, TBR'ing oshima.

[benwells, 2015-02-18 09:10:57]

The CQ bit was checked by benwells@chromium.org

[commit-bot: I haz the power, 2015-02-18 09:11:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/934503002/80001

[commit-bot: I haz the power, 2015-02-18 09:47:50]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-02-18 09:48:41]

Patchset 5 (id:??) landed as
https://crrev.com/cc4dc2dea6c65c7e03c560c678c2b57b4d217fa8
Cr-Commit-Position: refs/heads/master@{#316790}