Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 933483002: add Method param to drawTextOnPath, supporting SVG spec

Created:
5 years, 10 months ago by reed2
Modified:
5 years, 10 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

add Method param to drawTextOnPath, supporting SVG spec needs SK_SUPPORT_LEGACY_DRAWTEXTONPATH to disable in chrome BUG=skia:

Patch Set 1 #

Patch Set 2 : add guard for android #

Total comments: 9

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+207 lines, -93 lines) Patch
M gm/bitmapscroll.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M gm/shadertext.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M gm/shadertext2.cpp View 1 2 4 chunks +17 lines, -15 lines 0 comments Download
M gyp/skia_for_android_framework_defines.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
M include/core/SkCanvas.h View 4 chunks +37 lines, -4 lines 0 comments Download
M include/core/SkDevice.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M include/core/SkPicture.h View 1 chunk +2 lines, -1 line 0 comments Download
M include/utils/SkDeferredCanvas.h View 1 chunk +2 lines, -1 line 0 comments Download
M include/utils/SkDumpCanvas.h View 1 chunk +2 lines, -1 line 0 comments Download
M include/utils/SkLuaCanvas.h View 1 chunk +2 lines, -1 line 0 comments Download
M include/utils/SkNWayCanvas.h View 1 chunk +2 lines, -1 line 0 comments Download
M samplecode/SampleAll.cpp View 1 chunk +4 lines, -2 lines 0 comments Download
M samplecode/SampleShaderText.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M samplecode/SampleSlides.cpp View 3 chunks +13 lines, -11 lines 0 comments Download
M samplecode/SampleTextOnPath.cpp View 3 chunks +18 lines, -13 lines 0 comments Download
M src/animator/SkTextOnPath.cpp View 1 chunk +5 lines, -2 lines 0 comments Download
M src/core/SkCanvas.cpp View 3 chunks +21 lines, -7 lines 0 comments Download
M src/core/SkDevice.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkPictureData.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/core/SkPicturePlayback.cpp View 1 chunk +5 lines, -1 line 0 comments Download
M src/core/SkPictureRecord.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/core/SkPictureRecord.cpp View 1 chunk +7 lines, -3 lines 0 comments Download
M src/core/SkReadBuffer.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/core/SkRecordDraw.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkRecorder.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/core/SkRecorder.cpp View 1 chunk +4 lines, -1 line 0 comments Download
M src/core/SkRecords.h View 2 chunks +11 lines, -1 line 0 comments Download
M src/pipe/SkGPipeRead.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M src/pipe/SkGPipeWrite.cpp View 3 chunks +6 lines, -2 lines 0 comments Download
M src/svg/SkSVGDevice.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/svg/SkSVGDevice.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M src/utils/SkDeferredCanvas.cpp View 2 chunks +6 lines, -5 lines 0 comments Download
M src/utils/SkDumpCanvas.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M src/utils/SkLuaCanvas.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M src/utils/SkNWayCanvas.cpp View 1 chunk +4 lines, -2 lines 0 comments Download
M src/utils/debugger/SkDebugCanvas.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/utils/debugger/SkDebugCanvas.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M src/utils/debugger/SkDrawCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/PictureTest.cpp View 3 chunks +5 lines, -2 lines 0 comments Download
M tests/SurfaceTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
reed2
ptal -- meant to meet SVG spec
5 years, 10 months ago (2015-02-16 03:38:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/933483002/20001
5 years, 10 months ago (2015-02-16 03:40:22 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 10 months ago (2015-02-16 03:40:24 UTC) #5
reed2
not fully implemented, just trying out the plumbing...
5 years, 10 months ago (2015-02-16 03:58:20 UTC) #7
f(malita)
5 years, 10 months ago (2015-02-16 15:31:50 UTC) #8 
Mostly formatting nits, plumbing l g t m (deferring to Robert).

https://codereview.chromium.org/933483002/diff/20001/include/utils/SkDeferred...
File include/utils/SkDeferredCanvas.h (right):

https://codereview.chromium.org/933483002/diff/20001/include/utils/SkDeferred...
include/utils/SkDeferredCanvas.h:165: SK_SUPPORT_LEGACY_DRAWTEXTONPATH_PARAM
const SkPaint&) SK_OVERRIDE;
indentation

https://codereview.chromium.org/933483002/diff/20001/include/utils/SkDumpCanv...
File include/utils/SkDumpCanvas.h (right):

https://codereview.chromium.org/933483002/diff/20001/include/utils/SkDumpCanv...
include/utils/SkDumpCanvas.h:99: SK_SUPPORT_LEGACY_DRAWTEXTONPATH_PARAM const
SkPaint&) SK_OVERRIDE;
indentation

https://codereview.chromium.org/933483002/diff/20001/include/utils/SkLuaCanvas.h
File include/utils/SkLuaCanvas.h (right):

https://codereview.chromium.org/933483002/diff/20001/include/utils/SkLuaCanva...
include/utils/SkLuaCanvas.h:40: SK_SUPPORT_LEGACY_DRAWTEXTONPATH_PARAM const
SkPaint&) SK_OVERRIDE;
indentation

https://codereview.chromium.org/933483002/diff/20001/include/utils/SkNWayCanv...
File include/utils/SkNWayCanvas.h (right):

https://codereview.chromium.org/933483002/diff/20001/include/utils/SkNWayCanv...
include/utils/SkNWayCanvas.h:51: SK_SUPPORT_LEGACY_DRAWTEXTONPATH_PARAM const
SkPaint&) SK_OVERRIDE;
indentation

https://codereview.chromium.org/933483002/diff/20001/src/core/SkPicturePlayba...
File src/core/SkPicturePlayback.cpp (right):

https://codereview.chromium.org/933483002/diff/20001/src/core/SkPicturePlayba...
src/core/SkPicturePlayback.cpp:368: method =
(SkCanvas::TextOnPathMethod)reader->readInt();
SkASSERT(method == ... || method == ...)?

https://codereview.chromium.org/933483002/diff/20001/src/core/SkPictureRecord...
File src/core/SkPictureRecord.cpp (right):

https://codereview.chromium.org/933483002/diff/20001/src/core/SkPictureRecord...
src/core/SkPictureRecord.cpp:645: SK_SUPPORT_LEGACY_DRAWTEXTONPATH_PARAM const
SkPaint& paint) {
indentation

https://codereview.chromium.org/933483002/diff/20001/src/core/SkPictureRecord.h
File src/core/SkPictureRecord.h (right):

https://codereview.chromium.org/933483002/diff/20001/src/core/SkPictureRecord...
src/core/SkPictureRecord.h:171: SK_SUPPORT_LEGACY_DRAWTEXTONPATH_PARAM const
SkPaint&) SK_OVERRIDE;
indentation

https://codereview.chromium.org/933483002/diff/20001/src/pipe/SkGPipeWrite.cpp
File src/pipe/SkGPipeWrite.cpp (right):

https://codereview.chromium.org/933483002/diff/20001/src/pipe/SkGPipeWrite.cp...
src/pipe/SkGPipeWrite.cpp:261: SK_SUPPORT_LEGACY_DRAWTEXTONPATH_PARAM const
SkPaint&) SK_OVERRIDE;
indentation

https://codereview.chromium.org/933483002/diff/20001/src/utils/SkDeferredCanv...
File src/utils/SkDeferredCanvas.cpp (right):

https://codereview.chromium.org/933483002/diff/20001/src/utils/SkDeferredCanv...
src/utils/SkDeferredCanvas.cpp:895: SK_SUPPORT_LEGACY_DRAWTEXTONPATH_PARAM const
SkPaint& paint) {
indentation

Powered by Google App Engine
This is Rietveld 408576698