Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(581)

Unified Diff: public/platform/Platform.h

Issue 933323002: Add experimental Support for DOM3 KeyboardEvent key value (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Added key=value pair for screencastview.js Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: public/platform/Platform.h
diff --git a/public/platform/Platform.h b/public/platform/Platform.h
index 0f2d2bbfb334aa8f8fdb842a0fb158eb3bf0d8af..43bf102bc2db34d7660253a588a806d018fd5416 100644
--- a/public/platform/Platform.h
+++ b/public/platform/Platform.h
@@ -618,6 +618,18 @@ public:
// Returns 0, if DOM code enum is not found.
virtual int domEnumFromCodeString(const WebString& codeString) { return 0; }
+ // This method converts from the supplied DOM key enum to the
Wez 2015/03/04 23:00:26 "... from the supplied embedder |key| enum to the
Habib Virji 2015/03/09 15:14:27 Done.
+ // embedder's DOM key string value for the key pressed. |domKey| values are
+ // based on the value defined in ui/events/keycodes/dom3/dom_key_data.h.
Wez 2015/03/04 23:00:25 That header is a Chromium header - at the level if
Habib Virji 2015/03/09 15:14:27 On 2015/03/04 23:00:25, Wez wrote: In dom |code| C
+ // Returns null string, if DOM key value is not found.
Wez 2015/03/04 23:00:26 Do you mean returns null if the |domKey| value is
Habib Virji 2015/03/09 15:14:27 It is empty, corrected.
+ virtual WebString domKeyStringFromEnum(int domKey) { return WebString(); }
+
+ // This method converts from the suppled DOM Key value to the
Wez 2015/03/04 23:00:25 nit: Capitalization of "Key" vs "key" in the previ
Habib Virji 2015/03/09 15:14:27 Done.
+ // embedder's DOM key enum for the key pressed. |keyString| is defined in
+ // ui/events/keycodes/dom3/dom_key_data.h.
Wez 2015/03/04 23:00:26 See above; the returned domEnum values are opaque
Habib Virji 2015/03/09 15:14:27 Please suggest, rbyers did mention to include even
+ // Returns 0, if DOM key enum is not found.
Wez 2015/03/04 23:00:25 nit: Remove the comma
Habib Virji 2015/03/09 15:14:27 Done.
+ virtual int domEnumFromKeyString(const WebString& keyString) { return 0; }
Wez 2015/03/04 23:00:26 domKeyEnumFromString
Habib Virji 2015/03/09 15:14:27 Done.
+
// Quota -----------------------------------------------------------
// Queries the storage partition's storage usage and quota information.

Powered by Google App Engine
This is Rietveld 408576698