Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Side by Side Diff: public/platform/Platform.h

Issue 933323002: Add experimental Support for DOM3 KeyboardEvent key value (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Added key=value pair for screencastview.js Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 600 matching lines...) Expand 10 before | Expand all | Expand 10 after
611 // based on the value defined in ui/events/keycodes/dom4/keycode_converter_d ata.h. 611 // based on the value defined in ui/events/keycodes/dom4/keycode_converter_d ata.h.
612 // Returns null string, if DOM code value is not found. 612 // Returns null string, if DOM code value is not found.
613 virtual WebString domCodeStringFromEnum(int domCode) { return WebString(); } 613 virtual WebString domCodeStringFromEnum(int domCode) { return WebString(); }
614 614
615 // This method converts from the suppled DOM code value to the 615 // This method converts from the suppled DOM code value to the
616 // embedder's DOM code enum for the key pressed. |codeString| is defined in 616 // embedder's DOM code enum for the key pressed. |codeString| is defined in
617 // ui/events/keycodes/dom4/keycode_converter_data.h. 617 // ui/events/keycodes/dom4/keycode_converter_data.h.
618 // Returns 0, if DOM code enum is not found. 618 // Returns 0, if DOM code enum is not found.
619 virtual int domEnumFromCodeString(const WebString& codeString) { return 0; } 619 virtual int domEnumFromCodeString(const WebString& codeString) { return 0; }
620 620
621 // This method converts from the supplied DOM key enum to the
Wez 2015/03/04 23:00:26 "... from the supplied embedder |key| enum to the
Habib Virji 2015/03/09 15:14:27 Done.
622 // embedder's DOM key string value for the key pressed. |domKey| values are
623 // based on the value defined in ui/events/keycodes/dom3/dom_key_data.h.
Wez 2015/03/04 23:00:25 That header is a Chromium header - at the level if
Habib Virji 2015/03/09 15:14:27 On 2015/03/04 23:00:25, Wez wrote: In dom |code| C
624 // Returns null string, if DOM key value is not found.
Wez 2015/03/04 23:00:26 Do you mean returns null if the |domKey| value is
Habib Virji 2015/03/09 15:14:27 It is empty, corrected.
625 virtual WebString domKeyStringFromEnum(int domKey) { return WebString(); }
626
627 // This method converts from the suppled DOM Key value to the
Wez 2015/03/04 23:00:25 nit: Capitalization of "Key" vs "key" in the previ
Habib Virji 2015/03/09 15:14:27 Done.
628 // embedder's DOM key enum for the key pressed. |keyString| is defined in
629 // ui/events/keycodes/dom3/dom_key_data.h.
Wez 2015/03/04 23:00:26 See above; the returned domEnum values are opaque
Habib Virji 2015/03/09 15:14:27 Please suggest, rbyers did mention to include even
630 // Returns 0, if DOM key enum is not found.
Wez 2015/03/04 23:00:25 nit: Remove the comma
Habib Virji 2015/03/09 15:14:27 Done.
631 virtual int domEnumFromKeyString(const WebString& keyString) { return 0; }
Wez 2015/03/04 23:00:26 domKeyEnumFromString
Habib Virji 2015/03/09 15:14:27 Done.
632
621 // Quota ----------------------------------------------------------- 633 // Quota -----------------------------------------------------------
622 634
623 // Queries the storage partition's storage usage and quota information. 635 // Queries the storage partition's storage usage and quota information.
624 // WebStorageQuotaCallbacks::didQueryStorageUsageAndQuota will be called 636 // WebStorageQuotaCallbacks::didQueryStorageUsageAndQuota will be called
625 // with the current usage and quota information for the partition. When 637 // with the current usage and quota information for the partition. When
626 // an error occurs WebStorageQuotaCallbacks::didFail is called with an 638 // an error occurs WebStorageQuotaCallbacks::didFail is called with an
627 // error code. 639 // error code.
628 virtual void queryStorageUsageAndQuota( 640 virtual void queryStorageUsageAndQuota(
629 const WebURL& storagePartition, 641 const WebURL& storagePartition,
630 WebStorageQuotaType, 642 WebStorageQuotaType,
(...skipping 30 matching lines...) Expand all
661 673
662 virtual WebNavigatorConnectProvider* navigatorConnectProvider() { return 0; } 674 virtual WebNavigatorConnectProvider* navigatorConnectProvider() { return 0; }
663 675
664 protected: 676 protected:
665 virtual ~Platform() { } 677 virtual ~Platform() { }
666 }; 678 };
667 679
668 } // namespace blink 680 } // namespace blink
669 681
670 #endif 682 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698