Source/web/tests/WebInputEventConversionTest.cpp - Issue 933323002: Add experimental Support for DOM3 KeyboardEvent key value

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/tests/WebInputEventConversionTest.cpp

Issue 933323002: Add experimental Support for DOM3 KeyboardEvent key value (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Added key=value pair for screencastview.js Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/tests/WebInputEventConversionTest.cpp

diff --git a/Source/web/tests/WebInputEventConversionTest.cpp b/Source/web/tests/WebInputEventConversionTest.cpp

index a9548c0facd3926d079cecc886189c388ef2abac..2988b0f490d81a335b7619985e84abefebc8816f 100644

--- a/Source/web/tests/WebInputEventConversionTest.cpp

+++ b/Source/web/tests/WebInputEventConversionTest.cpp

@@ -57,7 +57,7 @@ namespace {

PassRefPtrWillBeRawPtr<KeyboardEvent> createKeyboardEventWithLocation(KeyboardEvent::KeyLocationCode location)

{

- return KeyboardEvent::create("keydown", true, true, 0, "", "", location, false, false, false, false);

+ return KeyboardEvent::create("keydown", true, true, 0, "", "", "", location, false, false, false, false);

}

int getModifiersForKeyLocationCode(KeyboardEvent::KeyLocationCode location)

@@ -731,7 +731,7 @@ TEST(WebInputEventConversionTest, PinchViewportOffset)

TEST(WebInputEventConversionTest, ElasticOverscroll)

{

- const std::string baseURL("http://www.test6.com/");

+ const std::string baseURL("http://www.test5.com/");

const std::string fileName("fixed_layout.html");

URLTestHelpers::registerMockedURLFromBaseURL(WebString::fromUTF8(baseURL.c_str()), WebString::fromUTF8("fixed_layout.html"));

@@ -792,7 +792,7 @@ TEST(WebInputEventConversionTest, ElasticOverscroll)

TEST(WebInputEventConversionTest, WebMouseWheelEventBuilder)

{

- const std::string baseURL("http://www.test5.com/");

+ const std::string baseURL("http://www.test6.com/");

Wez 2015/03/04 23:00:25 Why did these change?

Habib Virji 2015/03/09 15:14:27 In my previous CL i altered the sequence. So corre

const std::string fileName("fixed_layout.html");

URLTestHelpers::registerMockedURLFromBaseURL(WebString::fromUTF8(baseURL.c_str()), WebString::fromUTF8("fixed_layout.html"));

@@ -823,7 +823,7 @@ TEST(WebInputEventConversionTest, WebMouseWheelEventBuilder)

TEST(WebInputEventConversionTest, PlatformWheelEventBuilder)

{

- const std::string baseURL("http://www.test6.com/");

+ const std::string baseURL("http://www.test7.com/");

const std::string fileName("fixed_layout.html");

URLTestHelpers::registerMockedURLFromBaseURL(WebString::fromUTF8(baseURL.c_str()), WebString::fromUTF8("fixed_layout.html"));

« Source/devtools/protocol.json ('K') | « Source/web/WebInputEventConversion.cpp ('k') | Source/web/tests/WebPluginContainerTest.cpp » ('j') | public/platform/Platform.h » ('J')