Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(565)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 93263002: Move some more file utils to the base namespace. (Closed)

Created:
7 years ago by brettw
Modified:
7 years ago
Reviewers:
jam
CC:
chromium-reviews, asanka, vandebo (ex-Chrome), sadrul, nkostylev+watch_chromium.org, jbauman+watch_chromium.org, tzik, cc-bugs_chromium.org, amit, ilevy-cc_chromium.org, browser-components-watch_chromium.org, gavinp+memory_chromium.org, sievers+watch_chromium.org, yfriedman+watch_chromium.org, kinuko+watch, stevenjb+watch_chromium.org, danakj+watch_chromium.org, frankf+watch_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, benquan, jar (doing other things), benjhayden+dwatch_chromium.org, Ilya Sherman, jam, joi+watch-content_chromium.org, dcaiafa+watch_chromium.org, lambroslambrou+watch_chromium.org, darin-cc_chromium.org, jochen+watch_chromium.org, chromium-apps-reviews_chromium.org, erikwright+watch_chromium.org, Dane Wallinga, jamiewalch+watch_chromium.org, sanjeevr, dyu1, tbarzic+watch_chromium.org, fischman+watch_chromium.org, bulach+watch_chromium.org, Paweł Hajdan Jr., craigdh+watch_chromium.org, nhiroki, feature-media-reviews_chromium.org, weitaosu+watch_chromium.org, rmsousa+watch_chromium.org, Ian Vollick, oshima+watch_chromium.org, kalyank, piman+watch_chromium.org, sergeyu+watch_chromium.org, klundberg+watch_chromium.org, rouslan+autofillwatch_chromium.org, chrome-apps-syd-reviews_chromium.org, hclam+watch_chromium.org, garykac+watch_chromium.org, Lei Zhang, tfarina, wez+watch_chromium.org, mcasas+watch_chromium.org, ben+ash_chromium.org, asvitkine+watch_chromium.org, tommycli, eroman, robertshield, jshin+watch_chromium.org, Greg Billock, grt+watch_chromium.org, estade+watch_chromium.org, alexeypa+watch_chromium.org, James Su, wjia+watch_chromium.org, mmenke, davemoore+watch_chromium.org
Visibility:
Public.

Description

Move some more file utils to the base namespace. This also swaps the order of the parameters to GetShmemTempDir so the out parameter is last, and enhances some documentation. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238144

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+219 lines, -206 lines) Patch
M base/base_paths.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/base_paths_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/base_paths_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/file_util.h View 1 chunk +30 lines, -14 lines 0 comments Download
M base/file_util.cc View 2 chunks +8 lines, -8 lines 0 comments Download
M base/file_util_android.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M base/file_util_mac.mm View 2 chunks +2 lines, -5 lines 0 comments Download
M base/file_util_posix.cc View 6 chunks +110 lines, -109 lines 0 comments Download
M base/file_util_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M base/file_util_win.cc View 2 chunks +12 lines, -12 lines 0 comments Download
M base/files/file_util_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/files/scoped_temp_dir_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/memory/shared_memory_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/nix/mime_util_xdg.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/nix/xdg_util.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M base/os_compat_android_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/sys_info_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/file_cache_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/login_utils.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/diagnostics/sqlite_diagnostics.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/download/download_prefs.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media_galleries/fileapi/picasa_data_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/net_log_temp_file.h View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/net/net_log_temp_file.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/screenshot_taker.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/web_applications/web_app_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/web_applications/web_app_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/chrome_paths_linux.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/chrome_paths_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/importer/firefox_importer_utils_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/setup/setup_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/setup/uninstall.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/move_tree_work_item_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/installer/util/shell_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/tools/crash_service/main.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/chrome_frame_reporting.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/dom_storage/session_storage_database.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/common/plugin_list_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/browser/shell_browser_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M crypto/nss_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/socket/unix_domain_socket_posix_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M printing/backend/cups_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/branding.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/setup/daemon_controller_delegate_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/setup/daemon_controller_delegate_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M rlz/chromeos/lib/rlz_value_store_chromeos.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/browser/fileapi/native_file_util.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
brettw
TBR=jam
7 years ago (2013-12-02 18:54:48 UTC) #1
brettw
7 years ago (2013-12-02 18:55:56 UTC) #2
Message was sent while issue was closed. 
Committed patchset #3 manually as r238144.

Powered by Google App Engine
This is Rietveld 408576698