Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Side by Side Diff: base/os_compat_android_unittest.cc

Issue 93263002: Move some more file utils to the base namespace. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « base/nix/xdg_util.cc ('k') | base/sys_info_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/os_compat_android.h" 5 #include "base/os_compat_android.h"
6 6
7 #include "base/file_util.h" 7 #include "base/file_util.h"
8 #include "testing/gtest/include/gtest/gtest.h" 8 #include "testing/gtest/include/gtest/gtest.h"
9 9
10 namespace base { 10 namespace base {
11 11
12 typedef testing::Test OsCompatAndroidTest; 12 typedef testing::Test OsCompatAndroidTest;
13 13
14 // Keep this Unittest DISABLED_ , because it actually creates a directory in the 14 // Keep this Unittest DISABLED_ , because it actually creates a directory in the
15 // device and it may be source of flakyness. For any changes in the mkdtemp 15 // device and it may be source of flakyness. For any changes in the mkdtemp
16 // function, you should run this unittest in your local machine to check if it 16 // function, you should run this unittest in your local machine to check if it
17 // passes. 17 // passes.
18 TEST_F(OsCompatAndroidTest, DISABLED_TestMkdTemp) { 18 TEST_F(OsCompatAndroidTest, DISABLED_TestMkdTemp) {
19 FilePath tmp_dir; 19 FilePath tmp_dir;
20 EXPECT_TRUE(file_util::GetTempDir(&tmp_dir)); 20 EXPECT_TRUE(base::GetTempDir(&tmp_dir));
21 21
22 // Not six XXXXXX at the suffix of the path. 22 // Not six XXXXXX at the suffix of the path.
23 FilePath sub_dir = tmp_dir.Append("XX"); 23 FilePath sub_dir = tmp_dir.Append("XX");
24 std::string sub_dir_string = sub_dir.value(); 24 std::string sub_dir_string = sub_dir.value();
25 // this should be OK since mkdtemp just replaces characters in place 25 // this should be OK since mkdtemp just replaces characters in place
26 char* buffer = const_cast<char*>(sub_dir_string.c_str()); 26 char* buffer = const_cast<char*>(sub_dir_string.c_str());
27 EXPECT_EQ(NULL, mkdtemp(buffer)); 27 EXPECT_EQ(NULL, mkdtemp(buffer));
28 28
29 // Directory does not exist 29 // Directory does not exist
30 char invalid_path2[] = "doesntoexist/foobarXXXXXX"; 30 char invalid_path2[] = "doesntoexist/foobarXXXXXX";
31 EXPECT_EQ(NULL, mkdtemp(invalid_path2)); 31 EXPECT_EQ(NULL, mkdtemp(invalid_path2));
32 32
33 // Successfully create a tmp dir. 33 // Successfully create a tmp dir.
34 FilePath sub_dir2 = tmp_dir.Append("XXXXXX"); 34 FilePath sub_dir2 = tmp_dir.Append("XXXXXX");
35 std::string sub_dir2_string = sub_dir2.value(); 35 std::string sub_dir2_string = sub_dir2.value();
36 // this should be OK since mkdtemp just replaces characters in place 36 // this should be OK since mkdtemp just replaces characters in place
37 char* buffer2 = const_cast<char*>(sub_dir2_string.c_str()); 37 char* buffer2 = const_cast<char*>(sub_dir2_string.c_str());
38 EXPECT_TRUE(mkdtemp(buffer2) != NULL); 38 EXPECT_TRUE(mkdtemp(buffer2) != NULL);
39 } 39 }
40 40
41 } // namespace base 41 } // namespace base
OLDNEW
« no previous file with comments | « base/nix/xdg_util.cc ('k') | base/sys_info_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698