Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 930933006: Pass LoadUrlParams instead of just url to TabObserver.onLoadUrl (Closed)

Created:
5 years, 10 months ago by Yaron
Modified:
5 years, 10 months ago
CC:
chromium-reviews, David Trainor- moved to gerrit, avayvod+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Pass LoadUrlParams instead of just url to TabObserver.onLoadUrl Some observers will need more information than just the url. BUG=443773 Committed: https://crrev.com/d292b0128220f671368cc9ba22a3f85608a3ce94 Cr-Commit-Position: refs/heads/master@{#317588}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -3 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/EmptyTabObserver.java View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/Tab.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/TabObserver.java View 3 chunks +11 lines, -2 lines 0 comments Download

Messages

Total messages: 21 (8 generated)
Yaron
5 years, 10 months ago (2015-02-20 15:39:40 UTC) #2
newt (away)
lgtm
5 years, 10 months ago (2015-02-20 18:07:04 UTC) #3
gone
lgtm
5 years, 10 months ago (2015-02-20 18:48:25 UTC) #4
Jaekyun Seok (inactive)
lgtm
5 years, 10 months ago (2015-02-22 23:44:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/930933006/1
5 years, 10 months ago (2015-02-23 15:25:33 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/61630)
5 years, 10 months ago (2015-02-23 15:28:04 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/930933006/1
5 years, 10 months ago (2015-02-23 15:28:16 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/61632)
5 years, 10 months ago (2015-02-23 15:30:41 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/930933006/1
5 years, 10 months ago (2015-02-23 15:32:36 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/61635)
5 years, 10 months ago (2015-02-23 15:35:12 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/930933006/1
5 years, 10 months ago (2015-02-23 15:49:35 UTC) #19
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-23 15:59:26 UTC) #20
commit-bot: I haz the power
5 years, 10 months ago (2015-02-23 16:00:12 UTC) #21
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/d292b0128220f671368cc9ba22a3f85608a3ce94
Cr-Commit-Position: refs/heads/master@{#317588}

Powered by Google App Engine
This is Rietveld 408576698