chrome/android/java/src/org/chromium/chrome/browser/Tab.java - Issue 930933006: Pass LoadUrlParams instead of just url to TabObserver.onLoadUrl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/Tab.java

Issue 930933006: Pass LoadUrlParams instead of just url to TabObserver.onLoadUrl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/EmptyTabObserver.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/TabObserver.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/Tab.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/Tab.java b/chrome/android/java/src/org/chromium/chrome/browser/Tab.java

index 0ca6a7326c03caba84b56109116032fa87e7da60..92662fd7e7e8fd63abd08536e0f16bfa2ddc255f 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/Tab.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/Tab.java

@@ -780,7 +780,7 @@ public class Tab implements ViewGroup.OnHierarchyChangeListener,

params.getIsRendererInitiated(), params.getIntentReceivedTimestamp());

for (TabObserver observer : mObservers) {

- observer.onLoadUrl(this, params.getUrl(), loadType);

+ observer.onLoadUrl(this, params, loadType);

}

return loadType;

} finally {