Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1743)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/TabObserver.java

Issue 930933006: Pass LoadUrlParams instead of just url to TabObserver.onLoadUrl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/Tab.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/TabObserver.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/TabObserver.java b/chrome/android/java/src/org/chromium/chrome/browser/TabObserver.java
index ca914340ef5058bd86f6a7c75a810b28f472eb48..989defb680e2d3a6f8da1468da0f777881c653e4 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/TabObserver.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/TabObserver.java
@@ -7,6 +7,7 @@ package org.chromium.chrome.browser;
import android.view.ContextMenu;
import org.chromium.content.browser.ContentViewCore;
+import org.chromium.content_public.browser.LoadUrlParams;
import org.chromium.content_public.browser.WebContents;
/**
@@ -61,9 +62,16 @@ public interface TabObserver {
void onOverlayContentViewCoreRemoved(Tab tab, ContentViewCore content);
/**
+ * Use onLoadUrl(Tab, LoadUrlParams, int)
+ * TODO(yfriedman): Remove this
+ */
+ @Deprecated
+ void onLoadUrl(Tab tab, String url, int loadType);
+
+ /**
* Called when loadUrl is triggered on a a {@link Tab}.
* @param tab The notifying {@link Tab}.
- * @param url The url that is being loaded.
+ * @param params The params describe the page being loaded.
* @param loadType The type of load that was performed.
*
* @see TabLoadStatus#PAGE_LOAD_FAILED
@@ -71,7 +79,8 @@ public interface TabObserver {
* @see TabLoadStatus#PARTIAL_PRERENDERED_PAGE_LOAD
* @see TabLoadStatus#FULL_PRERENDERED_PAGE_LOAD
*/
- void onLoadUrl(Tab tab, String url, int loadType);
+ void onLoadUrl(Tab tab, LoadUrlParams params, int loadType);
+
/**
* Called when a tab has started to load a page.
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/Tab.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698